Bugzilla – Attachment 65450 Details for
Bug 19025
Move C4::Reserves::GetReserveInfo to Koha::Holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19025: Remove C4::Reserves::GetReserveInfo
Bug-19025-Remove-C4ReservesGetReserveInfo.patch (text/plain), 2.66 KB, created by
Marcel de Rooy
on 2017-08-03 06:38:10 UTC
(
hide
)
Description:
Bug 19025: Remove C4::Reserves::GetReserveInfo
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-08-03 06:38:10 UTC
Size:
2.66 KB
patch
obsolete
>From 0c2ff6319e83aa9b56aaf360d8a9dd25caf4f581 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 2 Aug 2017 11:52:11 -0300 >Subject: [PATCH] Bug 19025: Remove C4::Reserves::GetReserveInfo >Content-Type: text/plain; charset=utf-8 > >Test plan: > git grep GetReserveInfo >should not return results > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Reserves.pm | 54 ------------------------------------------------------ > 1 file changed, 54 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 04bd7d9..c3b2126 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -108,7 +108,6 @@ BEGIN { > &GetReservesForBranch > &GetReservesToBranch > &GetReserveCount >- &GetReserveInfo > &GetReserveStatus > > &GetOtherReserves >@@ -1231,59 +1230,6 @@ sub ModReserveMinusPriority { > _FixPriority({ reserve_id => $reserve_id, rank => '0' }); > } > >-=head2 GetReserveInfo >- >- &GetReserveInfo($reserve_id); >- >-Get item and borrower details for a current hold. >-Current implementation this query should have a single result. >- >-=cut >- >-sub GetReserveInfo { >- my ( $reserve_id ) = @_; >- my $dbh = C4::Context->dbh; >- my $strsth="SELECT >- reserve_id, >- reservedate, >- reservenotes, >- reserves.borrowernumber, >- reserves.biblionumber, >- reserves.branchcode, >- reserves.waitingdate, >- notificationdate, >- reminderdate, >- priority, >- found, >- firstname, >- surname, >- phone, >- email, >- address, >- address2, >- cardnumber, >- city, >- zipcode, >- biblio.title, >- biblio.author, >- items.holdingbranch, >- items.itemcallnumber, >- items.itemnumber, >- items.location, >- barcode, >- notes >- FROM reserves >- LEFT JOIN items USING(itemnumber) >- LEFT JOIN borrowers USING(borrowernumber) >- LEFT JOIN biblio ON (reserves.biblionumber=biblio.biblionumber) >- WHERE reserves.reserve_id = ?"; >- my $sth = $dbh->prepare($strsth); >- $sth->execute($reserve_id); >- >- my $data = $sth->fetchrow_hashref; >- return $data; >-} >- > =head2 IsAvailableForItemLevelRequest > > my $is_available = IsAvailableForItemLevelRequest($item_record,$borrower_record); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19025
:
65428
|
65429
|
65449
| 65450