Attachment 65493 Details for Bug 18344 – Bug 18344 - Allow overdue fines cap at replacement price, and cap by amount to work together

[patch] Bug 18344 - Allow overdue fines cap at replacement price, and cap by amount to work together

Bug-18344---Allow-overdue-fines-cap-at-replacement.patch (text/plain), 2.12 KB, created by Marcel de Rooy on 2017-08-04 07:37:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-08-04 07:37:43 UTC

Size: 2.12 KB

patch

obsolete

>From f44d471c3d5bd487ed1d74cedade460c3b511487 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 28 Mar 2017 11:05:28 +0000
>Subject: [PATCH] Bug 18344 - Allow overdue fines cap at replacement price, and
> cap by amount to work together
>Content-Type: text/plain; charset=utf-8
>
>There is no reason that a library shouldn't be able to use the monetary
>fines cap and the replacement price cap at the same time. The code is
>written in such a way that they already work harmoniously. We have
>librarians who wish to use both so they can set a high cap of $10.00 but
>also use the replacement price cap so that a $20.00 book would only get
>a fine of $10.00, but a $5.00 paperback will only get a fine of $5.00
>
>Test Plan:
>1) Apply this patch
>2) Create a rule with a fines cap of $10, *and* a cap at replacement price, and a daily fine of $1
>3) Create two items, one with a replacement price of $5 and one with a
>   replacement price of $15
>4) Check out these items to a patron, backdate the checkouts so they are
>   already overdue by a couple months
>5) Check the items in ( make sure calc fine at checkin is enabled for
>    you )
>6) Note the one item has a fine of $5 and the other has a fine of $10!
>
>Signed-off-by: David Kuhn <techservspec@gmail.com>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 0283d80..d0ce3e1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -33,9 +33,6 @@ $(document).ready(function() {
>         return confirmDelete(MSG_CONFIRM_DELETE);
>     });
> 
>-        $('#cap_fine_to_replacement_price').on('change', function(){
>-            $('#overduefinescap').prop('disabled', $(this).is(':checked') );
>-        });
>         $('#selectlibrary').find("input:submit").hide();
>         $('#branch').change(function() {
>                 $('#selectlibrary').submit();
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18344: 61658 | 62190 | 65493 | 86988 | 86989 | 89607 | 89608