Bugzilla – Attachment 65500 Details for
Bug 18985
SQL reports 'Last edit' and 'Last run' columns sort alphabetically, not chronologically
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18985 - SQL reports 'Last edit' and 'Last run' columns sort alphabetically, not chronologically
Bug-18985---SQL-reports-Last-edit-and-Last-run-col.patch (text/plain), 2.54 KB, created by
Marc Véron
on 2017-08-04 14:09:58 UTC
(
hide
)
Description:
Bug 18985 - SQL reports 'Last edit' and 'Last run' columns sort alphabetically, not chronologically
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-08-04 14:09:58 UTC
Size:
2.54 KB
patch
obsolete
>From 1a1786cb876795b9a84d707855d179738937c733 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 1 Aug 2017 17:07:33 +0000 >Subject: [PATCH] Bug 18985 - SQL reports 'Last edit' and 'Last run' columns > sort alphabetically, not chronologically >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch alters the DataTables configuration of the SQL reports list >so that date columns are identified via class rather than position. > >To test, apply the patch and go to Reports -> Use saved. > >Test the re-ordering of the creation date, last edit, and last run >columns. Each should sort correctly based on the date. > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 4c3b47e..5902b92 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -101,10 +101,8 @@ $("#delColumn").on("click",function(){ > 'aoColumnDefs': [ > { 'bSortable': false, 'bSearchable':false, 'aTargets': [0, -1] }, > { 'bSearchable': false, 'aTargets': [3] }, >- { "aTargets": [ 1, 2 ], "sType": "natural" } >- ], >- "aoColumns": [ >- null,null,null,null,null,null,null,null,{ "sType": "title-string" },null,null,null,[% IF (usecache) %]null,[% END %]null,null[% IF has_obsolete_reports %],null[% END %] >+ { "aTargets": [ 1, 2 ], "sType": "natural" }, >+ { "sType": "title-string", "aTargets" : [ "title-string" ] } > ], > 'oLanguage': { > 'sZeroRecords': _("No matching reports found") >@@ -387,9 +385,9 @@ canned reports and writing custom SQL reports.</p> > <th>Subgroup</th> > <th>Notes</th> > <th>Author</th> >- <th>Creation date</th> >- <th>Last edit</th> >- <th>Last run</th> >+ <th class="title-string">Creation date</th> >+ <th class="title-string">Last edit</th> >+ <th class="title-string">Last run</th> > <th>Public</th> > [% IF (usecache) %] <th>Cache expiry (seconds)</th> [% END %] > <th>Saved results</th> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18985
:
65423
|
65500
|
65849