Attachment 65505 Details for Bug 18754 – Bug 18754: [QA Follow-up] Tiny corrections

[patch] Bug 18754: [QA Follow-up] Tiny corrections

Bug-18754-QA-Follow-up-Tiny-corrections.patch (text/plain), 3.26 KB, created by Marcel de Rooy on 2017-08-04 14:49:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-08-04 14:49:53 UTC

Size: 3.26 KB

patch

obsolete

>From 632e8cab96e9a404bad52f32b4a3aab7ba889aa9 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 4 Aug 2017 16:44:51 +0200
>Subject: [PATCH] Bug 18754: [QA Follow-up] Tiny corrections
>Content-Type: text/plain; charset=utf-8
>
>Converted one INCLUDE directive to PROCESS; we are not changing variables here. (The PROCESS directive is slightly faster than INCLUDE because it avoids the need to localise (i.e. copy) the variable stash before processing the template.)
>
>Removed one vim inserted letter i.
>
>Error in [% IF ( XISBN.publicationyear ) _ ', ' _ XISBN.publicationyear %][% END %] The concatenation became part of the condition.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 71d82b9..77c7f9b 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -547,7 +547,7 @@
> <li id="tab_holdings">
> [% END %]
> [% BLOCK holding_tab_title %][% IF SeparateHoldings %][% LoginBranchname %] holdings[% ELSE %]Holdings[% END %][% END %]
>- <a href="#holdings">[% INCLUDE holding_tab_title %] [% UNLESS too_many_items %][% ' ( ' _ (itemloop.size || 0) _ ' )' %][% END %]</a>
>+ <a href="#holdings">[% PROCESS holding_tab_title %] [% UNLESS too_many_items %][% ' ( ' _ (itemloop.size || 0) _ ' )' %][% END %]</a>
> </li>
> [% IF (SeparateHoldings) %]
> <li><a href="#otherholdings">Other holdings [% ' ( ' _ (otheritemloop.size || 0) _ ' )' %]</a></li>
>@@ -664,7 +664,7 @@
> [% IF holds_count.defined || priority %]
> <div id="bib_holds">
> [% IF holds_count.defined %]
>- Total holds: [% holds_count %]i
>+ Total holds: [% holds_count %]
> [% END %]
> [% IF priority %]
> [% IF holds_count.defined %]
>@@ -1001,7 +1001,7 @@
> [% IF ( XISBN.publishercode ) %]
> [% XISBN.publishercode |html %]
> [% IF ( XISBN.place ) %]([% XISBN.place %])[% END %]
>- [% IF ( XISBN.publicationyear ) _ ', ' _ XISBN.publicationyear %][% END %]
>+ [% IF ( XISBN.publicationyear ) %][% ', ' _ XISBN.publicationyear %][% END %]
> [% IF ( XISBN.pages ) %][% XISBN.pages %] [% XISBN.illus %] [% XISBN.size %][% END %]
> 
> [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18754: 64132 | 64178 | 65412 | 65504 | 65505