Attachment 65573 Details for Bug 19050 – Bug 19050 - XSS Flaws in Quick spine label creator

[patch] Bug 19050 - XSS Flaws in Quick spine label creator

0001-Bug-19050-XSS-Flaws-in-Quick-spine-label-creator.patch (text/plain), 1.25 KB, created by Amit Gupta on 2017-08-07 15:22:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Amit Gupta

Created: 2017-08-07 15:22:47 UTC

Size: 1.25 KB

patch

obsolete

>From 9db022a5748bef92ee6da184de87ce43427e8e0a Mon Sep 17 00:00:00 2001
>From: Amit Gupta <amit.gupta@informaticsglobal.com>
>Date: Mon, 7 Aug 2017 20:49:56 +0530
>Subject: [PATCH] Bug 19050 - XSS Flaws in Quick spine label creator
>
>1. Hit /cgi-bin/koha/labels/spinelabel-home.pl
>2. Enter <IFRAME SRC="javascript:alert('XSS');"></IFRAME> barcode text box.
>3. Notice the iframe is executed
>4. Apply patch
>5. Reload page, and enter iframe again on barcode text box.
>6. Notice it is no longer executed
>---
> .../prog/en/modules/labels/spinelabel-print.tt     |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt
>index 85aaae4..7881d33 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt
>@@ -23,7 +23,7 @@
> </head>
> 	[% IF ( BarcodeNotFound ) %]
> 		<body id="labels_spinelabel-print" class="tools labels">
>-			<p>The barcode [% Barcode %] was not found.</p>
>+			<p>The barcode [% Barcode |html %] was not found.</p>
>             <p><a href="spinelabel-home.pl">Return to spine label printer</a></p>
> 		</body>
> 	[% ELSE %]
>-- 
>1.7.9.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 19050: 65573 | 65596 | 65887