Attachment 65593 Details for Bug 18624 – Bug 18624: Run time errors when searching authorities with Elastic search 5.3

[patch] Bug 18624: Run time errors when searching authorities with Elastic search 5.3

Bug-18624-Run-time-errors-when-searching-authoriti.patch (text/plain), 1.70 KB, created by Tomás Cohen Arazi (tcohen) on 2017-08-07 19:25:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-08-07 19:25:09 UTC

Size: 1.70 KB

patch

obsolete

>From 70e87a550000814cd4f4fd5cbaeecef545c200b8 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 16 Jun 2017 09:53:39 -0400
>Subject: [PATCH] Bug 18624: Run time errors when searching authorities with
> Elastic search 5.3
>
>It seems we have a syntax mismatch - any vs all
>
>all seems to the be list we expect so updating code that way
>
>To test:
>1 - Enabled Elasticsearch
>2 - Index some authorities
>3 - Perform a 'Search entire record' search
>4 - Internal server error (
>        Invalid marclist field provided: all at
>        /usr/local/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>        line 433.
>        )
>5 - Run:
>    $ sudo koha-shell kohadev
>   k$ cd kohaclone
>   k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>=> FAIL: Tests fail because 'any is used'
>6 - Apply patch
>7 - Search should work
>8 - Run:
>   k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>=> SUCCESS: Tests pass!
>9 Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Edited the test plan so it mentions the new tests
>---
> Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>index 2fe9236..4169211 100644
>--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>@@ -416,7 +416,7 @@ our $koha_to_index_name = {
>     'match-heading' => 'Match-heading',
>     'see-from'      => 'Match-heading-see-from',
>     thesaurus       => 'Subject-heading-thesaurus',
>-    any              => ''
>+    all              => ''
> };
> 
> sub build_authorities_query_compat {
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 18624: 64385 | 65591 | 65592 | 65593 | 65594 | 65882 | 65883 | 65884 | 65885 | 66020