Attachment 65601 Details for Bug 19052 – Bug 19052 - XSS Flaws in vendor search page

[patch] Bug 19052 - XSS Flaws in vendor search page

Bug-19052---XSS-Flaws-in-vendor-search-page.patch (text/plain), 1.50 KB, created by Chris Cormack on 2017-08-07 20:47:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2017-08-07 20:47:41 UTC

Size: 1.50 KB

patch

obsolete

>From a38f14f1d577fab7379858a5a80d0648b9896f6f Mon Sep 17 00:00:00 2001
>From: Amit Gupta <amit.gupta@informaticsglobal.com>
>Date: Mon, 7 Aug 2017 22:04:30 +0530
>Subject: [PATCH] Bug 19052 - XSS Flaws in vendor search page
>
>1. Hit /cgi-bin/koha/acqui/booksellers.pl
>2. Enter <IFRAME SRC="javascript:alert('XSS');"></IFRAME> vendor search box.
>3. Notice the iframe is executed.
>4. Apply patch.
>5. Reload page, and enter iframe again on vendor search box.
>6. Notice it is no longer executed.
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>index 02eda130fa..e9f44dcaec 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>@@ -55,7 +55,7 @@ $(document).ready(function() {
> [% INCLUDE 'header.inc' %]
> [% INCLUDE 'acquisitions-search.inc' %]
> 
>-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> &rsaquo; Search for vendor <em>[% supplier %]</em> </div>
>+<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> &rsaquo; Search for vendor <em>[% supplier |html %]</em> </div>
> 
> <div id="doc3" class="yui-t2">
>    
>-- 
>2.13.3

Actions: View | Diff | Splinter Review

Attachments on bug 19052: 65586 | 65587 | 65601 | 65602 | 65891 | 65892