Attachment 65633 Details for Bug 19059 – Bug 19059: Remove CancelReserve - do not log DELETE

[patch] Bug 19059: Remove CancelReserve - do not log DELETE

Bug-19059-Remove-CancelReserve---do-not-log-DELETE.patch (text/plain), 1.36 KB, created by Jonathan Druart on 2017-08-08 12:00:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-08-08 12:00:31 UTC

Size: 1.36 KB

patch

obsolete

>From 25ecdc59c669dc1bea43a628a50fa3679afc874a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 4 Aug 2017 10:44:56 -0300
>Subject: [PATCH] Bug 19059: Remove CancelReserve - do not log DELETE
>
>There is something wrong with the DELETE log, it should be replaced with
>a FILLED log.
>Anyway, here we do not want it to be logged.
>---
> C4/Reserves.pm | 2 +-
> Koha/Hold.pm   | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 20ad806411..697dd66921 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -1020,7 +1020,7 @@ sub ModReserveFill {
>         }
>     );
> 
>-    # FIXME Must call Koha::Hold->cancel ?
>+    # FIXME Must call Koha::Hold->cancel ? => No, should call ->filled and add the correct log
>     Koha::Old::Hold->new( $hold->unblessed() )->store();
> 
>     $hold->delete();
>diff --git a/Koha/Hold.pm b/Koha/Hold.pm
>index 5c6d000ce1..d27bbae693 100644
>--- a/Koha/Hold.pm
>+++ b/Koha/Hold.pm
>@@ -316,7 +316,7 @@ sub cancel {
>             $self->cancellationdate(dt_from_string);
>             $self->priority(0);
>             $self->_move_to_old;
>-            $self->delete;
>+            $self->SUPER::delete(); # Do not add a DELETE log
> 
>             # now fix the priority on the others....
>             C4::Reserves::_FixPriority({ biblionumber => $self->biblionumber });
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19059: 65607 | 65608 | 65609 | 65610 | 65611 | 65630 | 65631 | 65632 | 65633 | 65634 | 65636 | 65637 | 65638 | 65639 | 65640 | 66783 | 66930 | 66975 | 66976 | 66977 | 66978 | 66979 | 66980 | 66981