Attachment 65757 Details for Bug 11897 – Bug 11897: Follow up: Check syspref before stockrotation access.

[patch] Bug 11897: Follow up: Check syspref before stockrotation access.

Bug-11897-Follow-up-Check-syspref-before-stockrota.patch (text/plain), 5.23 KB, created by Alex Sassmannshausen on 2017-08-09 15:02:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Sassmannshausen

Created: 2017-08-09 15:02:39 UTC

Size: 5.23 KB

patch

obsolete

>From b47691f4dcf7bf5b2920efd55daf94ce06d99293 Mon Sep 17 00:00:00 2001
>From: Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com>
>Date: Thu, 6 Jul 2017 16:34:32 +0200
>Subject: [PATCH] Bug 11897: Follow up: Check syspref before stockrotation
> access.
>
>* koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc: Add
>  check for syspref.
>* koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc: Add check
>  for syspref.
>* koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt: Add
>  check for syspref.
>* tools/stockrotation.pl: Add check for syspref.
>* catalogue/stockrotation.pl: Add check for syspref.
>
>Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
>---
> catalogue/stockrotation.pl                                    | 6 ++++++
> koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc       | 4 +++-
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt   | 4 +++-
> tools/stockrotation.pl                                        | 7 +++++++
> 5 files changed, 20 insertions(+), 3 deletions(-)
>
>diff --git a/catalogue/stockrotation.pl b/catalogue/stockrotation.pl
>index 8969b5bb12..ff63b8a270 100755
>--- a/catalogue/stockrotation.pl
>+++ b/catalogue/stockrotation.pl
>@@ -39,6 +39,12 @@ use Koha::Util::StockRotation qw(:ALL);
> 
> my $input = new CGI;
> 
>+unless (C4::Context->preference('StockRotation')) {
>+    # redirect to Intranet home if self-check is not enabled
>+    print $input->redirect("/cgi-bin/koha/mainpage.pl");
>+    exit;
>+}
>+
> my %params = $input->Vars();
> 
> my $op = $params{op};
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>index 0253b8c90a..b32f60939e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>@@ -40,7 +40,7 @@
> [% IF ( issuehistoryview ) %]<li class="active">[% ELSE %]<li>[% END %]
> <a href="/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=[% biblio_object_id | url  %]" >Checkout history</a></li>
> [% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=CATALOGUING&amp;action=MODIFY&amp;object=[% biblio_object_id | url  %]">Modification log</a> </li>[% END %]
>-[% IF ( CAN_user_stockrotation_can_add_items_rotas ) %][% IF ( stockrotationview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/catalogue/stockrotation.pl?biblionumber=[% biblio_object_id %]">Rota</a> </li>[% END %]
>+[% IF ( CAN_user_stockrotation_can_add_items_rotas && Koha.Preference('StockRotation') ) %][% IF ( stockrotationview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/catalogue/stockrotation.pl?biblionumber=[% biblio_object_id %]">Rota</a> </li>[% END %]
> </ul>
> </div>
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
>index 81922736f8..d4a6ad2b1c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
>@@ -1,3 +1,5 @@
>+[% USE Koha %]
>+
> <script type="text/javascript">//<![CDATA[
>     $(document).ready(function() {
>         var path = location.pathname.substring(1);
>@@ -55,7 +57,7 @@
>     [% IF ( CAN_user_tools_batch_upload_patron_images ) %]
> 	<li><a href="/cgi-bin/koha/tools/picture-upload.pl">Upload patron images</a></li>
>     [% END %]
>-    [% IF ( CAN_user_stockrotation_can_edit_rotas ) %]
>+    [% IF ( CAN_user_stockrotation_can_edit_rotas && Koha.Preference('StockRotation') ) %]
>     <li><a href="/cgi-bin/koha/tools/stockrotation.pl">Stock rotation</a></li>
>     [% END %]
> </ul>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>index 4724d0089e..0ff70a27dd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>@@ -1,3 +1,5 @@
>+[% USE Koha %]
>+
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Tools</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -70,7 +72,7 @@
> 	<dd>Upload patron images in a batch or one at a time</dd>
>     [% END %]
> 
>-    [% IF ( CAN_user_stockrotation_can_edit_rotas ) %]
>+    [% IF ( CAN_user_stockrotation_can_edit_rotas && Koha.Preference('StockRotation') ) %]
>     <dt><a href="/cgi-bin/koha/tools/stockrotation.pl">Stock rotation</a></dt>
>     <dd>Manage Stock rotation rotas, rota stages and rota items</dd>
>     [% END %]
>diff --git a/tools/stockrotation.pl b/tools/stockrotation.pl
>index b3bf48a689..19f71ddee0 100755
>--- a/tools/stockrotation.pl
>+++ b/tools/stockrotation.pl
>@@ -28,6 +28,7 @@ use Modern::Perl;
> use CGI;
> 
> use C4::Auth;
>+use C4::Context;
> use C4::Output;
> 
> use Koha::Libraries;
>@@ -39,6 +40,12 @@ use Koha::Util::StockRotation qw(:ALL);
> 
> my $input = new CGI;
> 
>+unless (C4::Context->preference('StockRotation')) {
>+    # redirect to Intranet home if self-check is not enabled
>+    print $input->redirect("/cgi-bin/koha/mainpage.pl");
>+    exit;
>+}
>+
> my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     {
>         template_name   => 'tools/stockrotation.tt',
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 11897: 25887 | 58207 | 58208 | 58209 | 58210 | 58211 | 58212 | 58213 | 58214 | 58215 | 58216 | 58217 | 58218 | 58219 | 58280 | 58281 | 58687 | 58692 | 58693 | 58694 | 58695 | 58696 | 60175 | 60715 | 61825 | 61826 | 61827 | 61828 | 61829 | 61830 | 61831 | 61832 | 61833 | 61834 | 61835 | 61836 | 61837 | 61838 | 61839 | 61885 | 62730 | 62750 | 62751 | 62752 | 62753 | 62754 | 62755 | 62756 | 62757 | 62758 | 62759 | 62760 | 62761 | 62762 | 62763 | 62764 | 62765 | 62766 | 62767 | 63063 | 63064 | 63065 | 63066 | 63067 | 63068 | 63069 | 63070 | 63071 | 63072 | 63073 | 63074 | 63075 | 63076 | 63077 | 63078 | 63079 | 63080 | 63114 | 64850 | 64851 | 65715 | 65716 | 65717 | 65718 | 65719 | 65720 | 65721 | 65722 | 65723 | 65724 | 65725 | 65726 | 65727 | 65728 | 65729 | 65730 | 65731 | 65732 | 65733 | 65734 | 65735 | 65736 | 65737 | 65738 | 65739 | 65740 | 65741 | 65742 | 65743 | 65744 | 65745 | 65746 | 65747 | 65748 | 65749 | 65750 | 65751 | 65752 | 65753 | 65754 | 65755 | 65756 | 65757 | 65758 | 66381 | 70496 | 70497 | 70498 | 70499 | 70500 | 70501 | 70502 | 70503 | 70504 | 70505 | 70506 | 70507 | 70508 | 70509 | 70510 | 70511 | 70512 | 70513 | 70514 | 70515 | 70516 | 70517 | 70518 | 70519 | 70520 | 70521 | 70522 | 70523 | 70524 | 72124 | 72125 | 72126 | 72127 | 72128 | 74003 | 74004 | 74005 | 74006 | 74007 | 74008 | 74010 | 74011 | 74012 | 74013 | 74014 | 74015 | 74016 | 74017 | 74197 | 74198 | 74199 | 74200 | 74201 | 74202 | 74203 | 74204 | 74205 | 74206 | 74319 | 74320 | 74360 | 74459 | 74460 | 74461 | 74462 | 74463 | 74464 | 74465 | 74466 | 74467 | 74468 | 74469 | 74470 | 75409 | 75410 | 75411 | 75412 | 75413 | 75414 | 75415 | 75416 | 75417 | 75418 | 75419 | 75420 | 76121 | 76122 | 76123 | 76124 | 76125 | 76126 | 76127 | 76128 | 76129 | 76130 | 76131 | 76132 | 76133 | 76134 | 76135 | 76144 | 76706 | 76707 | 76708 | 76709 | 76710 | 77623 | 77624 | 77625 | 77626 | 78387 | 78388 | 78389 | 78390 | 78391 | 78392 | 78393 | 78394 | 78404 | 78405 | 78406 | 78407 | 78408 | 79040 | 79041 | 79042 | 79043 | 79044 | 79738 | 79739 | 79740 | 79741 | 79742 | 79746 | 79747 | 79748 | 79749 | 79750 | 79964 | 79965 | 79966 | 79967 | 79968 | 79969 | 79970 | 79971 | 79972 | 79973 | 79974 | 79975 | 80068 | 80087 | 80088 | 80089 | 80090 | 80091 | 80092 | 80093 | 80094 | 80095 | 80096 | 80097 | 80098 | 80099 | 80100 | 80118 | 80260 | 80261 | 80262 | 80263 | 80264 | 80265 | 80266 | 80267 | 80268 | 80269 | 80270 | 80271 | 80272 | 80273 | 80274 | 80275 | 80289 | 80298 | 80299 | 80300