Bugzilla – Attachment 65824 Details for
Bug 12598
New misc/import_borrowers.pl command line tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Allow matched patron to be updated
0001-Bug-12598-Allow-matched-patron-to-be-updated.patch (text/plain), 1.10 KB, created by
Colin Campbell
on 2017-08-10 14:55:48 UTC
(
hide
)
Description:
Allow matched patron to be updated
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2017-08-10 14:55:48 UTC
Size:
1.10 KB
patch
obsolete
>From b3905a6e8a417d92005c89751bdf40797495d225 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 10 Aug 2017 13:56:24 +0100 >Subject: [PATCH] Bug 12598 Allow matched patron to be updated > >When a test was introduced to not add duplicate userids >it overlooked that if you were matching on userid you >do not want the update to be rejected. > >Add a test to overcome this logical flaw if updating >by matching userid >--- > Koha/Patrons/Import.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm >index db6beb0481..c785604766 100644 >--- a/Koha/Patrons/Import.pm >+++ b/Koha/Patrons/Import.pm >@@ -199,7 +199,7 @@ sub import_patrons { > } > > # Check if the userid provided does not exist yet >- if ( exists $borrower{userid} >+ if ( $matchpoint ne 'userid' and exists $borrower{userid} > and $borrower{userid} > and not Check_Userid( $borrower{userid}, $borrower{borrowernumber} ) ) { > push @errors, { duplicate_userid => 1, userid => $borrower{userid} }; >-- >2.13.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12598
:
29807
|
29808
|
29809
|
29939
|
30755
|
30780
|
35557
|
35558
|
35559
|
35560
|
35848
|
35849
|
35850
|
35851
|
35964
|
36684
|
36685
|
36687
|
36688
|
36690
|
36692
|
36693
|
36694
|
36695
|
36696
|
39124
|
39125
|
39126
|
39127
|
39128
|
41790
|
41791
|
41792
|
41793
|
41794
|
44065
|
44066
|
44067
|
44068
|
44069
|
48753
|
48754
|
48755
|
48756
|
48757
|
50693
|
50694
|
50695
|
50696
|
50697
|
50698
|
50699
|
50700
|
50704
|
51122
|
51357
|
51358
|
51359
|
51360
|
51361
|
51362
|
51363
|
51364
|
51365
|
51366
|
51367
|
51368
|
51369
|
51370
|
51371
|
51372
|
52323
|
52324
|
52325
|
52326
|
52327
|
52328
|
52329
|
52330
|
52331
|
52332
|
52333
|
52540
|
64437
|
64438
|
64855
|
65214
|
65215
|
65216
|
65217
|
65218
|
65819
|
65820
|
65821
|
65822
|
65823
|
65824
|
66353
|
66354
|
66355
|
66356
|
66357
|
66358
|
66359
|
66575
|
66576
|
66577
|
66578
|
66579
|
66580
|
66581
|
66582
|
67276
|
67277
|
70265
|
70266
|
71755
|
71756
|
71757
|
71758
|
71759
|
71760
|
71761
|
71762
|
71763
|
71764
|
71765
|
71766