Bugzilla – Attachment 65830 Details for
Bug 19076
Renewal via Checkout screen is logged as both a renewal and a checkout
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19076 - Move issue logging in AddIssue into condtional clause
Bug-19076---Move-issue-logging-in-AddIssue-into-co.patch (text/plain), 1.54 KB, created by
Nick Clemens (kidclamp)
on 2017-08-10 15:24:24 UTC
(
hide
)
Description:
Bug 19076 - Move issue logging in AddIssue into condtional clause
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-08-10 15:24:24 UTC
Size:
1.54 KB
patch
obsolete
>From 181178abba586bd1ac025b8177d66d571e7f968d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 10 Aug 2017 15:20:58 +0000 >Subject: [PATCH] Bug 19076 - Move issue logging in AddIssue into condtional > clause > >Currently AddIssue tests if renewal, but logs an issue even if so. This >patch moves the logging into the conditional so a log entry is only >added if we aren't renewing (as renewals are logged separately) > >To test: >1 - prove t/db_dependent/Circulation.t - one test should fail >2 - Enable both issue and renewal logs >3 - Checkout an item to a patron >4 - View the logs - the issue is captured >5 - Checkout the item to the patron again and confirm renewal >6 - Both an issue and a renewal are logged >7 - Apply patch >8 Repeat 1-6, tests should pass and only renewal should be logged >--- > C4/Circulation.pm | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index fba723f..0c1163b 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1451,13 +1451,12 @@ sub AddIssue { > } > ); > } >+ logaction( >+ "CIRCULATION", "ISSUE", >+ $borrower->{'borrowernumber'}, >+ $item->{'itemnumber'} >+ ) if C4::Context->preference("IssueLog"); > } >- >- logaction( >- "CIRCULATION", "ISSUE", >- $borrower->{'borrowernumber'}, >- $item->{'itemnumber'} >- ) if C4::Context->preference("IssueLog"); > } > return $issue; > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19076
:
65829
|
65830
|
65907
|
65908
|
65916
|
65939
|
66701
|
66702
|
66703