Attachment 65831 Details for Bug 5471 – Bug 5471: Use uri_escape_utf8 to handle utf8 chars correctly

[patch] Bug 5471: Use uri_escape_utf8 to handle utf8 chars correctly

Bug-5471-Use-uriescapeutf8-to-handle-utf8-chars-co.patch (text/plain), 1.54 KB, created by Jonathan Druart on 2017-08-10 16:15:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-08-10 16:15:53 UTC

Size: 1.54 KB

patch

obsolete

>From 8bbb035e66521d08290fc0addc8403d3af052f25 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 10 Aug 2017 13:15:27 -0300
>Subject: [PATCH] Bug 5471: Use uri_escape_utf8 to handle utf8 chars correctly
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> tags/review.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/tags/review.pl b/tags/review.pl
>index 009966d7d8..f1484f1a87 100755
>--- a/tags/review.pl
>+++ b/tags/review.pl
>@@ -63,13 +63,13 @@ if (is_ajax()) {
> 	my ($tag, $js_reply);
> 	if ($tag = $input->param('test')) {
> 		my $check = is_approved($tag);
>-        $js_reply = ( $check >=  1 ? 'success' : $check <= -1 ? 'failure' : 'indeterminate' ) . "_test('".uri_escape($tag)."');\n";
>+        $js_reply = ( $check >=  1 ? 'success' : $check <= -1 ? 'failure' : 'indeterminate' ) . "_test('".uri_escape_utf8($tag)."');\n";
> 	}
> 	if ($tag = $input->param('ok')) {
>-        $js_reply = (   whitelist($operator,$tag) ? 'success' : 'failure') . "_approve('".uri_escape($tag)."');\n";
>+        $js_reply = (   whitelist($operator,$tag) ? 'success' : 'failure') . "_approve('".uri_escape_utf8($tag)."');\n";
> 	} 
> 	if ($tag = $input->param('rej')) {
>-        $js_reply = (   blacklist($operator,$tag) ? 'success' : 'failure')  . "_reject('".uri_escape($tag)."');\n";
>+        $js_reply = (   blacklist($operator,$tag) ? 'success' : 'failure')  . "_reject('".uri_escape_utf8($tag)."');\n";
> 	}
> 	output_with_http_headers $input, undef, $js_reply, 'js';
> 	exit;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 5471: 64129 | 64208 | 65334 | 65831