Bugzilla – Attachment 65836 Details for
Bug 19042
Silence warnings t/db_dependent/Letters.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19042: Add mock IndependentBranches=0 for the other test
Bug-19042-Add-mock-IndependentBranches0-for-the-ot.patch (text/plain), 1.18 KB, created by
Jonathan Druart
on 2017-08-10 18:03:57 UTC
(
hide
)
Description:
Bug 19042: Add mock IndependentBranches=0 for the other test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-08-10 18:03:57 UTC
Size:
1.18 KB
patch
obsolete
>From dc273e2a6ab4c4cc81d7af8390a5bfb03b9c7753 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 10 Aug 2017 15:02:23 -0300 >Subject: [PATCH] Bug 19042: Add mock IndependentBranches=0 for the other test > >These tests do not cover correctly getletter, but it is not the goal of >this patch. Superlibrarian behaviour must be tested as well. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Letters.t | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index c0a8a5d..a08603b 100644 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -184,6 +184,7 @@ is( $letters->[0]->{name}, 'my name', 'GetLetters gets the name correctly' ); > # getletter > subtest 'getletter' => sub { > plan tests => 16; >+ t::lib::Mocks::mock_preference('IndependentBranches', 0); > my $letter = C4::Letters::getletter('my module', 'my code', $library->{branchcode}, 'email'); > is( $letter->{branchcode}, $library->{branchcode}, 'GetLetters gets the branch code correctly' ); > is( $letter->{module}, 'my module', 'GetLetters gets the module correctly' ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19042
:
65510
|
65511
|
65835
| 65836