Attachment 65929 Details for Bug 19086 – Bug 19086 Stored XSS in circulation.pl

[patch] Bug 19086 Stored XSS in circulation.pl

Bug-19086-Stored-XSS-in-circulationpl.patch (text/plain), 1.77 KB, created by Chris Cormack on 2017-08-11 19:56:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2017-08-11 19:56:36 UTC

Size: 1.77 KB

patch

obsolete

>From bb6d6d89b5157504c85b46324d5ae1d5b7523647 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chris@bigballofwax.co.nz>
>Date: Fri, 11 Aug 2017 19:54:34 +0000
>Subject: [PATCH] Bug 19086 Stored XSS in circulation.pl
>
>1/ To test add a message to a borrower that contains js
>2/ hit /cgi-bin/koha/circ/circulation.pl?borrowernumber=[number]
> where number is the borrowernumber of the borrower you set the message
> for
>3/ Notice js is execute
>4/ Apply patch, reload, js is escaped
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index ed054ae..0eb96b6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -868,7 +868,7 @@ No patron matched [% message | html %]
> [% IF message.manager_id %]
> ( <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% message.manager_id %]">[% message.get_column('manager_firstname') %] [% message.get_column('manager_surname') %]</a> )
> [% END %]
>- "[% message.message %]"
>+ "[% message.message | html %]"
> 
> [% IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion') %]
> <a class="btn btn-link btn-sm" href="/cgi-bin/koha/circ/del_message.pl?message_id=[% message.message_id %]&amp;borrowernumber=[% message.borrowernumber %]" onclick="return confirm(MSG_CONFIRM_DELETE_MESSAGE);"> Delete</a>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19086: 65927 | 65929 | 65958 | 65960 | 65965 | 65966 | 65967 | 65968 | 65969 | 65970 | 65972 | 65984 | 65985 | 65986 | 65987 | 66058 | 66059 | 66060 | 66061 | 66062 | 66063 | 66433 | 66434 | 66435 | 66436 | 66437 | 66438