Bugzilla – Attachment 65933 Details for
Bug 19089
XSS issue in supplier.pl page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19089 - XSS issue in supplier.pl page
0004-Bug-19089-XSS-issue-in-supplier.pl-page.patch (text/plain), 1.26 KB, created by
Amit Gupta
on 2017-08-12 03:43:16 UTC
(
hide
)
Description:
Bug 19089 - XSS issue in supplier.pl page
Filename:
MIME Type:
Creator:
Amit Gupta
Created:
2017-08-12 03:43:16 UTC
Size:
1.26 KB
patch
obsolete
>From cd9ed5c65e1d4050e1b0fbd9e8b0599a0b254adc Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Sat, 12 Aug 2017 09:09:53 +0530 >Subject: [PATCH 4/4] Bug 19089 - XSS issue in supplier.pl page > >1. Hit /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx<script>alert('amit')</script>. > xx - is a booksellerid >2. Notice the java script is executed. >4. Apply patch. >5. Reload page, and hit the page again /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx<script>alert('amit')</script>. > xx - is a booksellerid. >6. Notice it is no longer executed. >--- > acqui/supplier.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/acqui/supplier.pl b/acqui/supplier.pl >index e0addbc..44fbbf6 100755 >--- a/acqui/supplier.pl >+++ b/acqui/supplier.pl >@@ -42,6 +42,7 @@ To know the bookseller this script has to display details. > > use strict; > use warnings; >+use HTML::Entities; > use C4::Auth; > use C4::Contract; > use C4::Biblio; >@@ -66,6 +67,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > } > ); > my $booksellerid = $query->param('booksellerid'); >+$booksellerid = HTML::Entities::encode($booksellerid); > my $supplier; > if ($booksellerid) { > $supplier = Koha::Acquisition::Booksellers->find( $booksellerid ); >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19089
:
65933
|
65934
|
65935
|
66030