Bugzilla – Attachment 65960 Details for
Bug 19086
Multiple cross-site scripting vulnerabilities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19086 Stored XSS in circulation.pl
0001-Bug-19086-Stored-XSS-in-circulation.pl.patch (text/plain), 1.32 KB, created by
Amit Gupta
on 2017-08-14 16:22:33 UTC
(
hide
)
Description:
Bug 19086 Stored XSS in circulation.pl
Filename:
MIME Type:
Creator:
Amit Gupta
Created:
2017-08-14 16:22:33 UTC
Size:
1.32 KB
patch
obsolete
>From 81d5e12a73e9db20a1e7506bcf9b45387aa0dfa0 Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Mon, 14 Aug 2017 21:47:35 +0530 >Subject: [PATCH] Bug 19086 Stored XSS in circulation.pl > >1. Hit /cgi-bin/koha/circ/circulation.pl?borrowernumber=xx<script>alert('amit')</script>. > xx - is a borrowernumber >2. Notice the java script is executed. >4. Apply patch. >5. Reload page, and hit the page again /cgi-bin/koha/circ/circulation.pl?borrowernumber=xx<script>alert('amit')</script>. > xx - is a borrowernumber. >6. Notice it is no longer executed. >--- > circ/circulation.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index fad8623..38c50ac 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -29,6 +29,7 @@ use warnings; > use CGI qw ( -utf8 ); > use DateTime; > use DateTime::Duration; >+use HTML::Entities; > use C4::Output; > use C4::Print; > use C4::Auth qw/:DEFAULT get_session haspermission/; >@@ -106,6 +107,7 @@ $barcodes = [ uniq @$barcodes ]; > > my $template_name = q|circ/circulation.tt|; > my $borrowernumber = $query->param('borrowernumber'); >+$borrowernumber = HTML::Entities::encode($borrowernumber); > my $patron = $borrowernumber ? Koha::Patrons->find( $borrowernumber ) : undef; > my $batch = $query->param('batch'); > my $batch_allowed = 0; >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19086
:
65927
|
65929
|
65958
|
65960
|
65965
|
65966
|
65967
|
65968
|
65969
|
65970
|
65972
|
65984
|
65985
|
65986
|
65987
|
66058
|
66059
|
66060
|
66061
|
66062
|
66063
|
66433
|
66434
|
66435
|
66436
|
66437
|
66438