Bugzilla – Attachment 66004 Details for
Bug 19024
Order cancelled status is reset on basket close
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Correct original patch to test status == complete
0001-Bug-19024-Do-not-unset-order-cancelled-status-on-bas.patch (text/plain), 1.33 KB, created by
Colin Campbell
on 2017-08-15 10:31:24 UTC
(
hide
)
Description:
Correct original patch to test status == complete
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2017-08-15 10:31:24 UTC
Size:
1.33 KB
patch
obsolete
>From 7b9632ade1c89ee3d4da441fed0e12dac52288a2 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Wed, 2 Aug 2017 17:12:44 +0100 >Subject: [PATCH] Bug 19024 Do not unset order cancelled status on basket close > >On closing a basket, status is updated to ordered for orders not >completed. However the operation was resetting the status for >cancelled as well as new orders. >While display is correct from the basket view (it checks the >cancellation date). The status in the acquisitions tab from the >catalogue view reverts erroneously to ordered. > >This patch adds cancelled to the statuses not updated on basket >close. >--- > C4/Acquisition.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index ebbe44b106..d0381ce4ad 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -240,8 +240,10 @@ sub CloseBasket { > my $dbh = C4::Context->dbh; > $dbh->do('UPDATE aqbasket SET closedate=now() WHERE basketno=?', {}, $basketno ); > >- $dbh->do( q{UPDATE aqorders SET orderstatus = 'ordered' WHERE basketno = ? AND orderstatus != 'complete'}, >- {}, $basketno); >+ $dbh->do( >+q{UPDATE aqorders SET orderstatus = 'ordered' WHERE basketno = ? AND orderstatus NOT IN ( 'complete', 'cancelled')}, >+ {}, $basketno >+ ); > return; > } > >-- >2.13.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19024
:
65434
|
65439
|
65776
|
66004
|
66005
|
66039
|
66040
|
66041
|
66042
|
66043
|
66044
|
66725
|
66726
|
66727