Bugzilla – Attachment 6602 Details for
Bug 7226
Can't add tags on list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 7226 - can't add tags on list
SIGNED-OFF-Bug-7226---cant-add-tags-on-list.patch (text/plain), 3.62 KB, created by
Nicole C. Engard
on 2011-12-06 16:05:36 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 7226 - can't add tags on list
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2011-12-06 16:05:36 UTC
Size:
3.62 KB
patch
obsolete
>From 9a60aaf16a4fc09e6e747e8c1b7bd2adde0e1f60 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 6 Dec 2011 09:53:05 -0500 >Subject: [PATCH] [SIGNED-OFF] Bug 7226 - can't add tags on list > >Incorrect check for TagsInputOnList was preventing the >right JavaScript from being triggered, and markup was >nested inside the wrong logic for the confirmation >message to be displayed consistently. > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >--- > .../opac-tmpl/prog/en/modules/opac-shelves.tt | 26 ++++++++++---------- > 1 files changed, 13 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt >index 528b8a7..8fff936 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt >@@ -92,7 +92,6 @@ $(function() { > $("#addtags").html("<a id=\"tagsel_tag\" href=\"#\">"+_("Tag")+"<\/a> |"); > > $(".tagbutton").click(KOHA.Tags.add_tag_button); >- [% IF ( TagsInputOnList ) %] > [% IF ( loggedinusername ) %] > $("#tagsel_tag").click(function(){ > tagSelected(); >@@ -112,7 +111,6 @@ $(function() { > return false; > }); > [% END %] >- [% END %] > [% END %][% END %][% END %] > [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %] > }); >@@ -278,14 +276,16 @@ $(function() { > [% END %][% ELSE %]This record has no items.[% END %]</span> > [% END %] > [% IF ( TagsEnabled ) %] >- [% IF ( TagsShowOnList ) %] >- [% IF ( itemsloo.TagLoop ) %] >- <div class="results_summary"> >- <span class="label">Tags:</span> >- <ul style="display: inline; list-style: none;">[% FOREACH TagLoo IN itemsloo.TagLoop %]<li style="display: inline; list-style: none;"><a href="/cgi-bin/koha/opac-search.pl?tag=[% TagLoo.term |url %]&q=[% TagLoo.term |url %]">[% TagLoo.term %]</a> <span class="weight">([% TagLoo.weight_total %])</span></li> >- [% END %] >- </ul> >- [% END %] >+ [% IF ( TagsShowOnList ) %] >+ [% IF ( itemsloo.TagLoop.size ) %] >+ <div class="results_summary"> >+ <span class="label">Tags:</span> >+ <ul style="display: inline; list-style: none;">[% FOREACH TagLoo IN itemsloo.TagLoop %]<li style="display: inline; list-style: none;"><a href="/cgi-bin/koha/opac-search.pl?tag=[% TagLoo.term |url %]&q=[% TagLoo.term |url %]">[% TagLoo.term %]</a> <span class="weight">([% TagLoo.weight_total %])</span></li> >+ [% END %] >+ </ul> >+ </div> >+ [% END %] >+ [% END %] > [% IF ( TagsInputOnList ) %] > [% IF ( loggedinusername ) %] > <form name="tagform[% itemsloo.biblionumber %]" method="post" action="/cgi-bin/koha/opac-tags.pl"> >@@ -299,10 +299,10 @@ $(function() { > [% ELSIF ( loop.first ) %]<span class="tagstatus" id="login4tags">Log in to add tags.</span> > [% END %] > [% END %] >- [% IF ( itemsloo.TagLoop ) %] >- </div>[% END %] >+ [% IF ( loggedinusername ) %] >+ <span id="newtag[% itemsloo.biblionumber %]_status" class="tagstatus" style="display:none;">Tag status here.</span> >+ [% END %] > [% END %] >- [% END %] > > <span class="results_summary actions"><span class="label">Actions:</span> > [% IF ( RequestOnOpac ) %] >-- >1.7.2.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7226
:
6600
| 6602 |
6603