Bugzilla – Attachment 66030 Details for
Bug 19089
XSS issue in supplier.pl page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19089 - XSS issue in supplier.pl page
0001-Bug-19089-XSS-issue-in-supplier.pl-page.patch (text/plain), 2.02 KB, created by
Amit Gupta
on 2017-08-15 17:17:31 UTC
(
hide
)
Description:
Bug 19089 - XSS issue in supplier.pl page
Filename:
MIME Type:
Creator:
Amit Gupta
Created:
2017-08-15 17:17:31 UTC
Size:
2.02 KB
patch
obsolete
>From 49c976f356baec763fc479cd080c4df2ce4d78e4 Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Tue, 15 Aug 2017 22:42:19 +0530 >Subject: [PATCH] Bug 19089 - XSS issue in supplier.pl page > >1. Hit /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx<script>alert('amit')</script> > xx - is a booksellerid >2. Notice the java script is executed. >3. Apply patch. >4. Reload page, and hit the page again /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx<script>alert('amit')</script> > xx - is a booksellerid. >5. Notice it is no longer executed. >--- > .../prog/en/includes/acquisitions-toolbar.inc | 2 +- > .../prog/en/modules/acqui/supplier.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc >index a82ab41..05ef76a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc >@@ -2,7 +2,7 @@ > //<![CDATA[ > function confirm_deletion() { > if (confirm(_("Are you sure you want to delete this vendor?"))) { >- window.location="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid %]&op=delete"; >+ window.location="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid |html %]&op=delete"; > } > } > //]]> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >index 760e9d2..db849a8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >@@ -95,7 +95,7 @@ > //<![CDATA[ > function confirm_deletion() { > if (confirm(_("Confirm deletion of this vendor ?"))) { >- window.location="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid %]&op=delete"; >+ window.location="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid |html %]&op=delete"; > } > } > >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19089
:
65933
|
65934
|
65935
| 66030