Bugzilla – Attachment 66040 Details for
Bug 19024
Order cancelled status is reset on basket close
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 19024 Fix some infelicities of phrasing in test messages
SIGNED-OFF-Bug-19024-Fix-some-infelicities-of-phra.patch (text/plain), 1.58 KB, created by
Mark Tompsett
on 2017-08-15 18:58:25 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 19024 Fix some infelicities of phrasing in test messages
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-08-15 18:58:25 UTC
Size:
1.58 KB
patch
obsolete
>From 891b1f53dba543c2ff04b2cf78154182e46dee37 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Tue, 15 Aug 2017 11:44:12 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 19024 Fix some infelicities of phrasing in > test messages > >The test messages were awkwardly phrased, re phrase them to >sound more natuaral. Patch is cosmetic (grammar) only > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > t/db_dependent/Acquisition/close_reopen_basket.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Acquisition/close_reopen_basket.t b/t/db_dependent/Acquisition/close_reopen_basket.t >index 750f1c5..191612a 100644 >--- a/t/db_dependent/Acquisition/close_reopen_basket.t >+++ b/t/db_dependent/Acquisition/close_reopen_basket.t >@@ -79,8 +79,8 @@ is ( scalar( map { $_->{orderstatus} eq 'ordered' ? 1 : () } @orders ), 2, "2 or > > C4::Acquisition::ReopenBasket( $basketno ); > @orders = C4::Acquisition::GetOrders( $basketno ); >-is ( scalar( map { $_->{orderstatus} eq 'ordered' ? 1 : () } @orders ), 0, "No order are ordered, the basket is reopen" ); >-is ( scalar( map { $_->{orderstatus} eq 'new' ? 1 : () } @orders ), 2, "2 orders are new, the basket is reopen" ); >+is ( scalar( map { $_->{orderstatus} eq 'ordered' ? 1 : () } @orders ), 0, "No order is ordered, the basket is reopened" ); >+is ( scalar( map { $_->{orderstatus} eq 'new' ? 1 : () } @orders ), 2, "2 orders are new, the basket is reopened" ); > > C4::Acquisition::DelOrder( $biblionumber1, $ordernumber1 ); > my ( $order ) = C4::Acquisition::GetOrders( $basketno, {cancelled => 1} ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19024
:
65434
|
65439
|
65776
|
66004
|
66005
|
66039
|
66040
|
66041
|
66042
|
66043
|
66044
|
66725
|
66726
|
66727