Bugzilla – Attachment 66059 Details for
Bug 19086
Multiple cross-site scripting vulnerabilities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 19086 Stored XSS in circulation.pl
SIGNED-OFF-Bug-19086-Stored-XSS-in-circulationpl.patch (text/plain), 1.90 KB, created by
Katrin Fischer
on 2017-08-16 11:08:27 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 19086 Stored XSS in circulation.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-08-16 11:08:27 UTC
Size:
1.90 KB
patch
obsolete
>From 7677906e142a37d793374fed1ef06600e6625d82 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chris@bigballofwax.co.nz> >Date: Fri, 11 Aug 2017 19:54:34 +0000 >Subject: [PATCH] [SIGNED OFF] Bug 19086 Stored XSS in circulation.pl > >1/ To test add a message to a borrower that contains js >2/ hit /cgi-bin/koha/circ/circulation.pl?borrowernumber=[number] > where number is the borrowernumber of the borrower you set the message > for >3/ Notice js is execute >4/ Apply patch, reload, js is escaped > >Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 163747d..0d3ea31 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -869,7 +869,7 @@ No patron matched <span class="ex">[% message | html %]</span> > [% IF message.manager_id %] > ( <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% message.manager_id %]">[% message.get_column('manager_firstname') %] [% message.get_column('manager_surname') %]</a> ) > [% END %] >- <i>"[% message.message %]"</i> >+ <i>"[% message.message | html %]"</i> > </span> > [% IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion') %] > <a class="btn btn-link btn-sm" href="/cgi-bin/koha/circ/del_message.pl?message_id=[% message.message_id %]&borrowernumber=[% message.borrowernumber %]" onclick="return confirm(MSG_CONFIRM_DELETE_MESSAGE);"><i class="fa fa-trash"></i> Delete</a> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19086
:
65927
|
65929
|
65958
|
65960
|
65965
|
65966
|
65967
|
65968
|
65969
|
65970
|
65972
|
65984
|
65985
|
65986
|
65987
|
66058
|
66059
|
66060
|
66061
|
66062
|
66063
|
66433
|
66434
|
66435
|
66436
|
66437
|
66438