Bugzilla – Attachment 6606 Details for
Bug 7323
Javascript error when editing list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Bug-7323-Javascript-error-when-editing-list.patch (text/plain), 2.01 KB, created by
Owen Leonard
on 2011-12-06 16:45:55 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-12-06 16:45:55 UTC
Size:
2.01 KB
patch
obsolete
>From e27b70dc3d7c38ee3d425f174cab41356f01ba89 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 6 Dec 2011 11:43:10 -0500 >Subject: [PATCH] Bug 7323 - Javascript error when editing list >Content-Type: text/plain; charset="utf-8" > >Correcting check for empty shlef name to prevent >javascript error. > >Also correcting unescaped ampersand. >--- > .../prog/en/modules/virtualshelves/shelves.tt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index d7a34a1..d4f8ec3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -95,7 +95,7 @@ function placeHold () { > var _alertString=""; > var alertString2; > >- if(f.addshelf.value.length ==0){ >+ if($("#shelfname").val() == ""){ > _alertString += _("- You must enter a List Name") + "\n"; > } > >@@ -349,7 +349,7 @@ function placeHold () { > <tr><th>List Name</th><th>Contents</th><th>Sort by</th><th>Type</th><th>Options</th></tr> > [% FOREACH shelveslooppri IN shelveslooppriv %] > [% IF ( shelveslooppri.toggle ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >- <td><a href="shelves.pl?[% IF ( shelveslooppri.showprivateshelves ) %]display=privateshelves&[% END %]viewshelf=[% shelveslooppri.shelf %]&shelfoff=[% shelfoff %]">[% shelveslooppri.shelfname |html %]</a></td> >+ <td><a href="shelves.pl?[% IF ( shelveslooppri.showprivateshelves ) %]display=privateshelves&[% END %]viewshelf=[% shelveslooppri.shelf %]&shelfoff=[% shelfoff %]">[% shelveslooppri.shelfname |html %]</a></td> > <td>[% shelveslooppri.count %] item(s)</td> > <td>[% IF ( shelveslooppri.authorsort ) %]Author[% ELSIF ( shelveslooppri.yearsort ) %]Year[% ELSE %]Title[% END %]</td> > <td>[% IF ( shelveslooppri.viewcategory1 ) %]Private[% END %] >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7323
:
6606
|
6718