Bugzilla – Attachment 66081 Details for
Bug 19108
Stored XSS in multiple scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 19108 - Stored XSS in classsources.pl
SIGNED-OFF-Bug-19108---Stored-XSS-in-classsourcesp.patch (text/plain), 1.95 KB, created by
Katrin Fischer
on 2017-08-16 11:55:11 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 19108 - Stored XSS in classsources.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-08-16 11:55:11 UTC
Size:
1.95 KB
patch
obsolete
>From d44c8d9cdc6221c50d30a0759657c82abf81a658 Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Tue, 15 Aug 2017 13:55:45 +0530 >Subject: [PATCH] [SIGNED OFF] Bug 19108 - Stored XSS in classsources.pl > >Fixed for both Classification sources & Classification filing rules > >To Test >1. first case classification source: Hit the page > /cgi-bin/koha/admin/classsources.pl?op=add_source > second case classification filing rules: > Hit the page /cgi-bin/koha/admin/classsources.pl?op=add_sort_rule >2. Add a text in the field Description that contains js >3. Save the page. >4. Notice js is execute >5. Apply patch and reload, the js is escaped > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >index be817dc..314b51e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >@@ -213,7 +213,7 @@ > [% FOREACH class_source IN class_sources %] > <tr> > <td>[% class_source.code %]</td> >- <td>[% class_source.description %]</td> >+ <td>[% class_source.description |html %]</td> > <td>[% IF ( class_source.used ) %]Yes[% ELSE %]No[% END %]</td> > <td>[% class_source.sortrule %]</td> > <td class="actions"> >@@ -247,7 +247,7 @@ > [% FOREACH class_sort_rule IN class_sort_rules %] > <tr> > <td>[% class_sort_rule.rule %]</td> >- <td>[% class_sort_rule.description %]</td> >+ <td>[% class_sort_rule.description |html %]</td> > <td>[% class_sort_rule.sort_routine %]</td> > <td class="actions"> > <a class="btn btn-default btn-xs" href="[% class_sort_rule.script_name %]?op=edit_sort_rule&sort_rule=[% class_sort_rule.rule |html %]"><i class="fa fa-pencil"></i> Edit</a> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19108
:
65997
|
65998
|
65999
|
66000
|
66001
|
66002
|
66079
|
66080
|
66081
|
66082
|
66083
|
66084
|
66085
|
66442
|
66443
|
66444
|
66445
|
66446
|
66447
|
66448
|
67085