Bugzilla – Attachment 66259 Details for
Bug 19126
Fix Members.t with IndependentBranches set
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 19126: Fix Members.t with IndependentBranches set
SIGNED-OFF-Bug-19126-Fix-Memberst-with-Independent.patch (text/plain), 1.57 KB, created by
Aleisha Amohia
on 2017-08-20 23:53:13 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 19126: Fix Members.t with IndependentBranches set
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2017-08-20 23:53:13 UTC
Size:
1.57 KB
patch
obsolete
>From 52c5d935eaeaa9aa390738bb0d074232ddf8e91a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 16 Aug 2017 13:15:19 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 19126: Fix Members.t with > IndependentBranches set > >If you enabled that pref, Members.t fails with: >t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63. > >The first one is: >t/db_dependent/Members.t .. 32/63 > Failed test 'Staff patron not deleted from list' > at t/db_dependent/Members.t line 304. > >Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the >state of this preference. >Trivially fixing it here by disabling the pref before the first call. > >Test plan: >[1] Do not apply this patch yet. Enable IndependentBranches. >[2] Run Members.t and observe that it fails. >[3] Apply this patch. And run Members.t again. It should pass now. > >Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> >--- > t/db_dependent/Members.t | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t >index f75652c..a933827 100755 >--- a/t/db_dependent/Members.t >+++ b/t/db_dependent/Members.t >@@ -293,6 +293,10 @@ $builder->build({ > }, > }); > >+# The following calls to GetBorrowersToExpunge are assuming that the pref >+# IndependentBranches is off. >+t::lib::Mocks::mock_preference('IndependentBranches', 0); >+ > my $owner = AddMember (categorycode => 'STAFFER', branchcode => $library2->{branchcode} ); > my $list1 = AddPatronList( { name => 'Test List 1', owner => $owner } ); > my @listpatrons = ($bor1inlist, $bor2inlist); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19126
:
66064
|
66259
|
66484