Bugzilla – Attachment 66282 Details for
Bug 18046
Problem with redirect on logout with CAS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 18046 CAS logout infinite redirect
SIGNED-OFF-Bug-18046-CAS-logout-infinite-redirect.patch (text/plain), 1.17 KB, created by
Katrin Fischer
on 2017-08-21 15:13:23 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 18046 CAS logout infinite redirect
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-08-21 15:13:23 UTC
Size:
1.17 KB
patch
obsolete
>From b950afca9f03ed3d415782b148a662ca00d30d08 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Wed, 2 Aug 2017 10:15:10 +1200 >Subject: [PATCH] [SIGNED OFF] Bug 18046 CAS logout infinite redirect > >To test (You need a CAS server and CAS configured in Koha) > >1/ Login using CAS in Koha >2/ Logout in Koha >3/ Notice you get redirected again and again >4/ Apply patch >5/ Login with CAS, then logout >6/ Notice logout works, but no longer infinitely redirected > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >Patch has been in production use for several months >on several instances. Fixes a critical bug. >--- > C4/Auth_with_cas.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Auth_with_cas.pm b/C4/Auth_with_cas.pm >index b69124b..e14c6e6 100644 >--- a/C4/Auth_with_cas.pm >+++ b/C4/Auth_with_cas.pm >@@ -66,6 +66,7 @@ sub getMultipleAuth { > sub logout_cas { > my ($query, $type) = @_; > my ( $cas, $uri ) = _get_cas_and_service($query, undef, $type); >+ $uri =~ s/\?logout\.x=1//; # We don't want to keep triggering a logout, if we got here, the borrower is already logged out of Koha > print $query->redirect( $cas->logout_url(url => $uri)); > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18046
:
66254
|
66282
|
66456