Attachment 66370 Details for Bug 18290 – Bug 18290: Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON::PP::Boolean :)

[patch] Bug 18290: Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON::PP::Boolean :)

Bug-18290-Fix-tdbdependentKohaObjectt-MojoJSONBool.patch (text/plain), 1.57 KB, created by Tomás Cohen Arazi (tcohen) on 2017-08-22 19:45:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-08-22 19:45:41 UTC

Size: 1.57 KB

patch

obsolete

>From a6523dee673f47791000e22f5ec04b77f981aa7c Mon Sep 17 00:00:00 2001
>From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>Date: Fri, 17 Mar 2017 08:09:05 +0200
>Subject: [PATCH] Bug 18290: Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool
> is a JSON::PP::Boolean :)
>
>Mojolicious 7.21 onwards, no longer returns Mojo::JSON::Bool-objects but JSON::PP instead.
>Which might be pretty smart.
>
>This version is required by bug 18137 and so this patch for the tests is
>needed.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Tested along with 18137 and its dependencies (libs).
>---
> t/db_dependent/Koha/Object.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t
>index ea06544d24..a506b89ccc 100755
>--- a/t/db_dependent/Koha/Object.t
>+++ b/t/db_dependent/Koha/Object.t
>@@ -159,10 +159,10 @@ subtest 'TO_JSON tests' => sub {
>     my $lost = $patron->TO_JSON()->{lost};
>     my $gonenoaddress = $patron->TO_JSON->{gonenoaddress};
> 
>-    ok( $lost->isa('Mojo::JSON::_Bool'), 'Boolean attribute type is correct' );
>+    ok( $lost->isa('JSON::PP::Boolean'), 'Boolean attribute type is correct' );
>     is( $lost, 1, 'Boolean attribute value is correct (true)' );
> 
>-    ok( $gonenoaddress->isa('Mojo::JSON::_Bool'), 'Boolean attribute type is correct' );
>+    ok( $gonenoaddress->isa('JSON::PP::Boolean'), 'Boolean attribute type is correct' );
>     is( $gonenoaddress, 0, 'Boolean attribute value is correct (false)' );
> 
>     ok( !isvstring($patron->borrowernumber), 'Integer values are not coded as strings' );
>-- 
>2.14.1

Actions: View | Diff | Splinter Review

Attachments on bug 18290: 61195 | 66370