Bugzilla – Attachment 66373 Details for
Bug 19163
Critical typo in stage-marc-import process
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19163: Critical typo in stage-marc-import process
Bug-19163-Critical-typo-in-stage-marc-import-proce.patch (text/plain), 1.83 KB, created by
Liz Rea
on 2017-08-22 22:48:05 UTC
(
hide
)
Description:
Bug 19163: Critical typo in stage-marc-import process
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2017-08-22 22:48:05 UTC
Size:
1.83 KB
patch
obsolete
>From fc20ec3cea01e90f9296904f3e5f0b2c80ad21f3 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 22 Aug 2017 16:41:46 +0200 >Subject: [PATCH] Bug 19163: Critical typo in stage-marc-import process > >Template says ISO2709 but script wants MARC or MARCXML.. >Slipped in with bug 19049. >Trivial but critical fix. > >Test plan: >Import a MARC file. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >I picked this fix because I think MARC is always ambiguous. ISO2709 >clearly denotes the serialization format used. > >Signed-off-by: Liz Rea <liz@catalyst.net.nz> >--- > tools/stage-marc-import.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/tools/stage-marc-import.pl b/tools/stage-marc-import.pl >index c845060..07a921f 100755 >--- a/tools/stage-marc-import.pl >+++ b/tools/stage-marc-import.pl >@@ -57,7 +57,7 @@ my $item_action = $input->param('item_action'); > my $comments = $input->param('comments'); > my $record_type = $input->param('record_type'); > my $encoding = $input->param('encoding') || 'UTF-8'; >-my $format = $input->param('format') || 'MARC'; >+my $format = $input->param('format') || 'ISO2709'; > my $marc_modification_template = $input->param('marc_modification_template_id'); > > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >@@ -91,7 +91,7 @@ if ($completedJobID) { > my ( $errors, $marcrecords ); > if( $format eq 'MARCXML' ) { > ( $errors, $marcrecords ) = C4::ImportBatch::RecordsFromMARCXMLFile( $file, $encoding); >- } elsif( $format eq 'MARC' ) { >+ } elsif( $format eq 'ISO2709' ) { > ( $errors, $marcrecords ) = C4::ImportBatch::RecordsFromISO2709File( $file, $record_type, $encoding ); > } else { # plugin based > $errors = []; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19163
:
66344
|
66346
|
66364
| 66373