Bugzilla – Attachment 6639 Details for
Bug 7093
Placeholders for suggestion table in suggestion related mails broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-7093-placeholds-for-suggestion-table-not-working.patch (text/plain), 1.83 KB, created by
Ian Walls
on 2011-12-07 16:47:14 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Ian Walls
Created:
2011-12-07 16:47:14 UTC
Size:
1.83 KB
patch
obsolete
>From a20446cf6bc69165f6ac719eabbcd9a71943c366 Mon Sep 17 00:00:00 2001 >From: Ian Walls <ian.walls@bywatersolutions.com> >Date: Wed, 7 Dec 2011 11:43:20 -0500 >Subject: [PATCH] Bug 7093: placeholds for suggestion table not working in notices > >In parseletter_sth, the suggestions table was defined twice. The first time (which >is the only definition to get called, as it matches first then exists), defined the >primary search keys as borrowernumber and biblionumber. This is incorrect; the only >usage of the suggestions table tokens is with suggestionid as the key. This is defined >further down the if/then chain. > >This patch removes the erroneous sth query definition. > >To test: > >1. Place a suggestion with a patron account with a configured email you can access >2. Approve or reject it >3. Verify the message you receive contains suggestion tokens (like title, author and reason) >--- > C4/Letters.pm | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 6846a00..862121c 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -490,7 +490,6 @@ sub parseletter_sth { > ($table eq 'biblioitems' ) ? "SELECT * FROM $table WHERE biblionumber = ?" : > ($table eq 'items' ) ? "SELECT * FROM $table WHERE itemnumber = ?" : > ($table eq 'issues' ) ? "SELECT * FROM $table WHERE itemnumber = ?" : >- ($table eq 'suggestions' ) ? "SELECT * FROM $table WHERE borrowernumber = ? and biblionumber = ?" : > ($table eq 'reserves' ) ? "SELECT * FROM $table WHERE borrowernumber = ? and biblionumber = ?" : > ($table eq 'borrowers' ) ? "SELECT * FROM $table WHERE borrowernumber = ?" : > ($table eq 'branches' ) ? "SELECT * FROM $table WHERE branchcode = ?" : >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7093
:
6639
|
6657