Attachment 66405 Details for Bug 10306 – Bug 10306: [QA Follow-up] Correct a TestBuilder call

[patch] Bug 10306: [QA Follow-up] Correct a TestBuilder call

Bug-10306-QA-Follow-up-Correct-a-TestBuilder-call.patch (text/plain), 1.55 KB, created by Marcel de Rooy on 2017-08-24 10:26:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-08-24 10:26:01 UTC

Size: 1.55 KB

patch

obsolete

>From 5e76db80ee803a1929f9b95b8261ad81b103c244 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 24 Aug 2017 12:23:29 +0200
>Subject: [PATCH] Bug 10306: [QA Follow-up] Correct a TestBuilder call
>Content-Type: text/plain; charset=utf-8
>
>In order to create a new framework, MarcSubfieldStructure was used as
>source. This works since that table contains a FK for frameworkcode.
>But obviously, we should use BiblioFramework as source.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Biblio/TransformKohaToMarc.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Biblio/TransformKohaToMarc.t b/t/db_dependent/Biblio/TransformKohaToMarc.t
>index 978861f..2222d6f 100644
>--- a/t/db_dependent/Biblio/TransformKohaToMarc.t
>+++ b/t/db_dependent/Biblio/TransformKohaToMarc.t
>@@ -91,7 +91,7 @@ subtest "Working with control fields in another framework" => sub {
> subtest "Add test for no_split option" => sub {
>     plan tests => 4;
> 
>-    my $fwc = t::lib::TestBuilder->new->build({ source => 'MarcSubfieldStructure' })->{frameworkcode};
>+    my $fwc = t::lib::TestBuilder->new->build({ source => 'BiblioFramework' })->{frameworkcode};
>     Koha::MarcSubfieldStructure->new({ frameworkcode => $fwc, tagfield => '952', tagsubfield => 'a', kohafield => 'items.fld1' })->store;
>     Koha::MarcSubfieldStructure->new({ frameworkcode => $fwc, tagfield => '952', tagsubfield => 'b', kohafield => 'items.fld1' })->store;
>     Koha::Caches->get_instance->clear_from_cache( "MarcSubfieldStructure-$fwc" );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 10306: 65539 | 65540 | 65541 | 65542 | 65543 | 65544 | 65545 | 65948 | 65949 | 65950 | 65951 | 65952 | 65953 | 66134 | 66135 | 66137 | 66138 | 66139 | 66140 | 66141 | 66142 | 66327 | 66328 | 66329 | 66330 | 66331 | 66332 | 66405 | 66547 | 66548 | 67501 | 67502 | 67503 | 67504 | 67505 | 67506 | 67507 | 68382 | 68766 | 68767 | 68768 | 68769 | 68770 | 68771 | 68772 | 68773