Attachment 66456 Details for Bug 18046 – Bug 18046 CAS logout infinite redirect

[patch] Bug 18046 CAS logout infinite redirect

Bug-18046-CAS-logout-infinite-redirect.patch (text/plain), 1.33 KB, created by Marcel de Rooy on 2017-08-25 07:04:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-08-25 07:04:18 UTC

Size: 1.33 KB

patch

obsolete

>From 89b2efad76d31f22bc5482ae13a0a23466d57d78 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Wed, 2 Aug 2017 10:15:10 +1200
>Subject: [PATCH] Bug 18046 CAS logout infinite redirect
>Content-Type: text/plain; charset=utf-8
>
>To test (You need a CAS server and CAS configured in Koha)
>
>1/ Login using CAS in Koha
>2/ Logout in Koha
>3/ Notice you get redirected again and again
>4/ Apply patch
>5/ Login with CAS, then logout
>6/ Notice logout works, but no longer infinitely redirected
>
>Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
>Patch has been in production use for several months
>on several instances. Fixes a critical bug.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Looks like a typical workaround, but evidently works.
>Not tested with CAS.
>---
> C4/Auth_with_cas.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Auth_with_cas.pm b/C4/Auth_with_cas.pm
>index b69124b..e14c6e6 100644
>--- a/C4/Auth_with_cas.pm
>+++ b/C4/Auth_with_cas.pm
>@@ -66,6 +66,7 @@ sub getMultipleAuth {
> sub logout_cas {
>     my ($query, $type) = @_;
>     my ( $cas, $uri ) = _get_cas_and_service($query, undef, $type);
>+    $uri =~ s/\?logout\.x=1//; # We don't want to keep triggering a logout, if we got here, the borrower is already logged out of Koha
>     print $query->redirect( $cas->logout_url(url => $uri));
> }
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18046: 66254 | 66282 | 66456