Attachment 66484 Details for Bug 19126 – Bug 19126: Fix Members.t with IndependentBranches set

[patch] Bug 19126: Fix Members.t with IndependentBranches set

Bug-19126-Fix-Memberst-with-IndependentBranches-se.patch (text/plain), 1.63 KB, created by Jonathan Druart on 2017-08-25 15:16:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-08-25 15:16:28 UTC

Size: 1.63 KB

patch

obsolete

>From 44a8fc5b9363eb27223f32e1150fb8fff6f55d08 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 16 Aug 2017 13:15:19 +0200
>Subject: [PATCH] Bug 19126: Fix Members.t with IndependentBranches set
>
>If you enabled that pref, Members.t fails with:
>t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63.
>
>The first one is:
>t/db_dependent/Members.t .. 32/63
>   Failed test 'Staff patron not deleted from list'
>   at t/db_dependent/Members.t line 304.
>
>Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the
>state of this preference.
>Trivially fixing it here by disabling the pref before the first call.
>
>Test plan:
>[1] Do not apply this patch yet. Enable IndependentBranches.
>[2] Run Members.t and observe that it fails.
>[3] Apply this patch. And run Members.t again. It should pass now.
>
>Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/db_dependent/Members.t | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t
>index f75652c267..a933827a30 100755
>--- a/t/db_dependent/Members.t
>+++ b/t/db_dependent/Members.t
>@@ -293,6 +293,10 @@ $builder->build({
>         },
> });
> 
>+# The following calls to GetBorrowersToExpunge are assuming that the pref
>+# IndependentBranches is off.
>+t::lib::Mocks::mock_preference('IndependentBranches', 0);
>+
> my $owner = AddMember (categorycode => 'STAFFER', branchcode => $library2->{branchcode} );
> my $list1 = AddPatronList( { name => 'Test List 1', owner => $owner } );
> my @listpatrons = ($bor1inlist, $bor2inlist);
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19126: 66064 | 66259 | 66484