Bugzilla – Attachment 66564 Details for
Bug 19088
plugins-upload.pl causes uninitialized value noise
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19088: plugins-upload causes error log noise
Bug-19088-plugins-upload-causes-error-log-noise.patch (text/plain), 1.53 KB, created by
Jonathan Druart
on 2017-08-28 19:34:59 UTC
(
hide
)
Description:
Bug 19088: plugins-upload causes error log noise
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-08-28 19:34:59 UTC
Size:
1.53 KB
patch
obsolete
>From 52ec8819ce055e9647ec3948248dc416b96b19be Mon Sep 17 00:00:00 2001 >From: Lee Jamison <ldjamison@marywood.edu> >Date: Fri, 11 Aug 2017 18:58:53 +0000 >Subject: [PATCH] Bug 19088: plugins-upload causes error log noise > >After uploading a plugin the error log indicates >use of uninitialized value in $op. This patch >silences the noise. > >To test: >1) Set <enable_plugins> to 1 (one) in koha-conf.xml. >2) Set the UseKohaPlugins system preference to 'Enable'. >3) Navigate to Administration -> Manage plugins. >4) Install the test plugin KPZ file attached to this bug. >5) Notice the uninitialized value noise in the error log. >6) Uninstall the plugin (plack restart may be required if plack is > enabled). >7) Apply patch. >8) Install the plugin again. >9) Notice no noise in the error log. >10) Run qa tools. >11) Run prove t/db_dependent/Plugins.t > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > plugins/plugins-upload.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/plugins/plugins-upload.pl b/plugins/plugins-upload.pl >index 1e315f9d0d..8a2ac26934 100755 >--- a/plugins/plugins-upload.pl >+++ b/plugins/plugins-upload.pl >@@ -47,7 +47,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > > my $uploadfilename = $input->param('uploadfile'); > my $uploadfile = $input->upload('uploadfile'); >-my $op = $input->param('op'); >+my $op = $input->param('op') || q{}; > > my ( $total, $handled, @counts, $tempfile, $tfh ); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19088
:
65926
|
65928
|
65936
| 66564