Attachment 6657 Details for Bug 7093 – [SIGNED-OFF] Bug 7093: placeholds for suggestion table not working in notices

[patch] [SIGNED-OFF] Bug 7093: placeholds for suggestion table not working in notices

SIGNED-OFF-Bug-7093-placeholds-for-suggestion-tabl.patch (text/plain), 2.05 KB, created by Katrin Fischer on 2011-12-08 05:46:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2011-12-08 05:46:48 UTC

Size: 2.05 KB

patch

obsolete

>From a5f6dea5ad790bc5b14e70a2fba111510a7d6c0b Mon Sep 17 00:00:00 2001
>From: Ian Walls <ian.walls@bywatersolutions.com>
>Date: Wed, 7 Dec 2011 11:43:20 -0500
>Subject: [PATCH] [SIGNED-OFF] Bug 7093: placeholds for suggestion table not
> working in notices
>
>In parseletter_sth, the suggestions table was defined twice.  The first time (which
>is the only definition to get called, as it matches first then exists), defined the
>primary search keys as borrowernumber and biblionumber.  This is incorrect; the only
>usage of the suggestions table tokens is with suggestionid as the key.  This is defined
>further down the if/then chain.
>
>This patch removes the erroneous sth query definition.
>
>To test:
>
>1.  Place a suggestion with a patron account with a configured email you can access
>2.  Approve or reject it
>3.  Verify the message you receive contains suggestion tokens (like title, author and reason)
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Suggestion mails for accepted, rejected and ordered look good now.
>I couldn't test the suggestion mail AVAILABLE (bug 7096), but
>assuming this would work too.
>---
> C4/Letters.pm |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 6846a00..862121c 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -490,7 +490,6 @@ sub parseletter_sth {
>     ($table eq 'biblioitems'  ) ? "SELECT * FROM $table WHERE   biblionumber = ?"                      :
>     ($table eq 'items'        ) ? "SELECT * FROM $table WHERE     itemnumber = ?"                      :
>     ($table eq 'issues'       ) ? "SELECT * FROM $table WHERE     itemnumber = ?"                      :
>-    ($table eq 'suggestions'  ) ? "SELECT * FROM $table WHERE borrowernumber = ? and biblionumber = ?" :
>     ($table eq 'reserves'     ) ? "SELECT * FROM $table WHERE borrowernumber = ? and biblionumber = ?" :
>     ($table eq 'borrowers'    ) ? "SELECT * FROM $table WHERE borrowernumber = ?"                      :
>     ($table eq 'branches'     ) ? "SELECT * FROM $table WHERE     branchcode = ?"                      :
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 7093: 6639 | 6657