Attachment 66642 Details for Bug 18779 – Bug 18779: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC)

[patch] Bug 18779: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC)

Bug-18779-Translatability-Get-rid-of-exposed-tt-di.patch (text/plain), 3.43 KB, created by Jonathan Druart on 2017-08-30 19:36:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-08-30 19:36:33 UTC

Size: 3.43 KB

patch

obsolete

>From a5e84b22edb399edbe9f178b43a0f6c2e7d4bb43 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Mon, 12 Jun 2017 08:20:56 +0200
>Subject: [PATCH] Bug 18779: Translatability: Get rid of exposed tt directives
> in authorities-search-results.inc (OPAC)
>
>The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc
>exposes template directives to translation where translators should not
>be confronted with.
>
>Example:
>"[%% PROCESS showreference heading=seeals.heading linkType='seealso' "
>"type=seeals.type authid=seeals.authid %%] "
>
>To test:
>- Apply patch
>- Verify that Authority search in OPAC works as before
>- Bonus test: create a new language 'aa-AA', verify that line above
>  does not show up in aa-AA-opac-bootstrap.po
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../en/includes/authorities-search-results.inc     | 28 ++++++++--------------
> 1 file changed, 10 insertions(+), 18 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authorities-search-results.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authorities-search-results.inc
>index 536d500497..8934ccafd5 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authorities-search-results.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authorities-search-results.inc
>@@ -1,11 +1,10 @@
> [% BLOCK showreference %]
>-[%#
>-    Parameters:
>-    heading: the heading itself
>-    linkType: currently 'seefrom' or 'seealso', controls the label for the entry
>-    type:
>-    authid: if it is a linked authority, its authid
>-%]
>+[%# Parameters: %]
>+[%# heading: the heading itself %]
>+[%# linkType: currently 'seefrom' or 'seealso', controls the label for the entry %]
>+[%# type: %]
>+[%# authid: if it is a linked authority, its authid %]
>+
>     [% SET authidurl = '/cgi-bin/koha/opac-authoritiesdetail.pl?authid=' %]
>     [% SET searchurl = '/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&marclist=mainentry&and_or=and&orderby=HeadingAsc&value=' %]
>     [% IF marcflavour == 'UNIMARC' %]
>@@ -93,11 +92,8 @@
>                     <span class="seefrom">used for/see from:</span>
>                 [% FOREACH seefro IN summary.seefrom %]
>                     <div class="seefrom authref">
>-                    [% PROCESS showreference
>-                        heading=seefro.heading
>-                        linkType='seefrom'
>-                        type=seefro.type
>-                    %]
>+                    [%# Following on one line for translatability %]
>+                    [% PROCESS showreference heading=seefro.heading linkType='seefrom' type=seefro.type %]
>                     </div>
>                 [% END %]
>             [% END %]
>@@ -105,12 +101,8 @@
>                     <span class="seealso">see also:</span>
>                 [% FOREACH seeals IN summary.seealso %]
>                     <div class="seealso authref">
>-                    [% PROCESS showreference
>-                        heading=seeals.heading
>-                        linkType='seealso'
>-                        type=seeals.type
>-                        authid=seeals.authid
>-                    %]
>+                    [%# Following on one line for translatability %]
>+                    [% PROCESS showreference heading=seeals.heading linkType='seealso' type=seeals.type authid=seeals.authid %]
>                     </div>
>                 [% END %]
>             [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18779: 64190 | 65398 | 66642