Bugzilla – Attachment 66699 Details for
Bug 16726
Text in Preferences search box does not clear
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16726: Clear text in syspref searchbox after submitting
Bug-16726-Clear-text-in-syspref-searchbox-after-su.patch (text/plain), 2.26 KB, created by
Nick Clemens (kidclamp)
on 2017-09-01 10:35:08 UTC
(
hide
)
Description:
Bug 16726: Clear text in syspref searchbox after submitting
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-09-01 10:35:08 UTC
Size:
2.26 KB
patch
obsolete
>From 76f0e3c3dab290d5937ed79a7b39566ee5457577 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Wed, 7 Jun 2017 02:09:36 +0000 >Subject: [PATCH] Bug 16726: Clear text in syspref searchbox after submitting > >To test: >1) Go to Admin -> search for a system preference >2) Notice your search stays in the search box (this is inconsistent with > search behaviour across Koha) >3) Apply patch and refresh page >4) Make another search >5) Confirm search still works as expected and search terms have been >cleared from search box >6) Confirm search terms show at the top of the results > >Sponsored-by: Catalyst IT > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc >index c7b2bba..4170576 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc >@@ -7,7 +7,7 @@ > <form action="/cgi-bin/koha/admin/preferences.pl"> > <input type="hidden" name="tab" value="[% last_tab %]" /> > <input type="hidden" name="op" value="search" /> >- <input class="head-searchbox" type="text" size="40" name="searchfield" value="[% searchfield |html %]" /> >+ <input class="head-searchbox" type="text" size="40" name="searchfield" value=""> > <input type="submit" class="submit" value="Search" /> > </form> > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index ed2aa03..550981a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -76,6 +76,8 @@ > <div class="dialog alert"> > No system preferences matched your search for: <strong>[% searchfield |html %]</strong> > </div> >+ [% ELSE %] >+ You searched for: <strong>[% searchfield | html %]</strong> > [% END %] > [% FOREACH TAB IN TABS %] > <div class="prefs-tab"> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16726
:
62340
|
62352
|
64072
|
64668
|
64669
|
64876
| 66699 |
66700
|
67551