Bugzilla – Attachment 66715 Details for
Bug 18621
After duplicate message system picks category expiry date rather than manual defined
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18621: Added in value attribute to dateexpiry field
Bug-18621-Added-in-value-attribute-to-dateexpiry-f.patch (text/plain), 2.56 KB, created by
Kyle M Hall (khall)
on 2017-09-01 11:43:47 UTC
(
hide
)
Description:
Bug 18621: Added in value attribute to dateexpiry field
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-09-01 11:43:47 UTC
Size:
2.56 KB
patch
obsolete
>From 5f3c014d70cb00b9a8533bbbc535de1205bae672 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Wed, 12 Jul 2017 10:09:48 +1200 >Subject: [PATCH] Bug 18621: Added in value attribute to dateexpiry field > >Test plan: >1. Create a patron category with the dateexpiry value of 29/9/2017 > >2. Create a patron user from that patron category (which I'll refer to as patron A) with the date >expiry value of 1/10/2017 and submit the form > >3. Notice that the manual dateexpiry you have submitted is correctly >displayed > >4. Create a duplicate patron with the same firstname and surname and >patron A, and set the date expiry value of 1/10/2017 and submit the form > >5. The form displays a duplicate patron message. Notice that the dateexpiry input box is empty now > >6. Select the new member (not a duplicate member) option in the >messagebox > >7. The form successfully submits and notice that the date expiry value >displayed is that of the patron category (i.e. it is 29/9/2017) not the >dateexpiry value of 1/10/2017 that you manually set for this patron > >8. Apply patch > >9. Repeat step 4 > >10. The form displays a duplicate patron message. Notice the dateexpiry input box still >contains the value you entered which is 1/10/2017. Select the new member >(not a duplicate member) option in the messagebox > >11. The form successfully submits and notice that the date expiry value >displayed is 1/10/2017 that you manually set for this patron > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index af75832..091486e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -787,7 +787,7 @@ $(document).ready(function() { > [% UNLESS ( opadd ) %] > <input type="text" id="to" name="dateexpiry" maxlength="10" size="10" value="[% dateexpiry UNLESS opduplicate %]" class="datepickerto" /> > [% ELSE %] >- <input type="text" id="to" name="dateexpiry" maxlength="10" size="10" class="datepickerto" /> >+ <input type="text" id="to" name="dateexpiry" maxlength="10" size="10" value="[% dateexpiry %]" class="datepickerto" /> > [% END %] > [% END %] > [% IF ( mandatorydateexpiry ) %]<span class="required">Required</span>[% END %] >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18621
:
65003
|
66102
| 66715