Attachment 6676 Details for Bug 6679 – [3.6.x] Bug 6679: catalogue/ now passing perl critic tests

[patch] [3.6.x] Bug 6679: catalogue/ now passing perl critic tests

Bug-6679-catalogue-now-passing-perl-critic-tests.patch (text/plain), 1.53 KB, created by Chris Cormack on 2011-12-08 19:26:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2011-12-08 19:26:14 UTC

Size: 1.53 KB

patch

obsolete

>From 65f45c2c1addf9c33ad52b320cf4ee79f9fe0607 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Mon, 31 Oct 2011 21:02:13 +1300
>Subject: [PATCH] Bug 6679: catalogue/ now passing perl critic tests
>
>Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
>---
> catalogue/showmarc.pl |    3 +--
> t/00-testcritic.t     |    4 ++--
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/catalogue/showmarc.pl b/catalogue/showmarc.pl
>index a54894b..b18068d 100755
>--- a/catalogue/showmarc.pl
>+++ b/catalogue/showmarc.pl
>@@ -23,8 +23,7 @@
> use strict;
> #use warnings; FIXME - Bug 2505
> 
>-use open OUT=>':utf8', ':std';
>-
>+use open OUT=>":encoding(UTF-8)", ':std';
> # standard or CPAN modules used
> use CGI qw(:standard);
> use DBI;
>diff --git a/t/00-testcritic.t b/t/00-testcritic.t
>index 19e53fb..c97828b 100755
>--- a/t/00-testcritic.t
>+++ b/t/00-testcritic.t
>@@ -16,8 +16,8 @@ my @all_koha_dirs = qw( acqui admin authorities basket C4 catalogue cataloguing
> labels members misc offline_circ opac patroncards reports reserve reviews rotating_collections
> serials sms suggestion t tags test tools virtualshelves);
> 
>-my @dirs = qw( acqui admin authorities basket circ debian errors offline_circ reserve reviews rotating_collections
>-serials sms virtualshelves );
>+my @dirs = qw( acqui admin authorities basket catalogue circ debian errors offline_circ reserve 
>+    reviews rotating_collections serials sms virtualshelves );
> 
> if ( not $ENV{TEST_QA} ) {
>     my $msg = 'Author test. Set $ENV{TEST_QA} to a true value to run';
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208