Attachment 66819 Details for Bug 18137 – Bug 18137: (QA followup) Make sure the session exists and is expired on expiration tests

[patch] Bug 18137: (QA followup) Make sure the session exists and is expired on expiration tests

Bug-18137-QA-followup-Make-sure-the-session-exists.patch (text/plain), 1.33 KB, created by Tomás Cohen Arazi (tcohen) on 2017-09-04 13:56:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-09-04 13:56:54 UTC

Size: 1.33 KB

patch

obsolete

>From c517da74decb2bb08c2101a803aa1b954af30cc4 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 9 Aug 2017 11:11:13 -0300
>Subject: [PATCH] Bug 18137: (QA followup) Make sure the session exists and is
> expired on expiration tests
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Lari Taskula <lari.taskula@jns.fi>
>---
> t/db_dependent/api/v1/auth.t | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/auth.t b/t/db_dependent/api/v1/auth.t
>index 0e324a8708..447028c060 100644
>--- a/t/db_dependent/api/v1/auth.t
>+++ b/t/db_dependent/api/v1/auth.t
>@@ -62,13 +62,13 @@ subtest 'under() tests' => sub {
>       ->json_is('/error', 'Authorization failure. Missing required permission(s).');
> 
>     # 401 (session expired)
>-    my $session = C4::Auth::get_session($session_id);
>-    $session->delete;
>-    $session->flush;
>+    t::lib::Mocks::mock_preference( 'timeout', '1' );
>+    ($borrowernumber, $session_id) = create_user_and_session();
>     $tx = $t->ua->build_tx( GET => "/api/v1/patrons" );
>     $tx->req->cookies(
>         { name => 'CGISESSID', value => $session_id } );
>     $tx->req->env( { REMOTE_ADDR => $remote_address } );
>+    sleep(2);
>     $t->request_ok($tx)
>       ->status_is(401)
>       ->json_is('/error', 'Session has been expired.');
>-- 
>2.14.1

Actions: View | Diff | Splinter Review

Attachments on bug 18137: 60490 | 60491 | 60492 | 60493 | 60494 | 60495 | 60533 | 60837 | 60838 | 60839 | 60840 | 60841 | 60842 | 60843 | 60866 | 60867 | 61163 | 61166 | 62780 | 62781 | 62782 | 62783 | 62784 | 62785 | 62786 | 62787 | 62788 | 62789 | 62816 | 63025 | 63026 | 63027 | 63028 | 63029 | 63030 | 63031 | 63032 | 63033 | 63034 | 63177 | 63178 | 63179 | 63180 | 63181 | 63182 | 63183 | 63184 | 63185 | 63186 | 63187 | 63188 | 63189 | 63190 | 63191 | 63192 | 63193 | 63194 | 63195 | 63196 | 63283 | 65106 | 65107 | 65108 | 65109 | 65110 | 65111 | 65112 | 65113 | 65114 | 65115 | 65404 | 65713 | 65714 | 66802 | 66803 | 66804 | 66805 | 66806 | 66807 | 66808 | 66809 | 66810 | 66811 | 66812 | 66813 | 66814 | 66815 | 66816 | 66817 | 66818 | 66819