Attachment 66920 Details for Bug 19228 – Bug 19228: Trigger confirm delete when removing item from course

[patch] Bug 19228: Trigger confirm delete when removing item from course

Bug-19228-Trigger-confirm-delete-when-removing-ite.patch (text/plain), 3.19 KB, created by Claire Gravely on 2017-09-07 10:09:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Claire Gravely

Created: 2017-09-07 10:09:38 UTC

Size: 3.19 KB

patch

obsolete

>From 094fd5dffef2146cb2990c29127c386cb6fb2eab Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Thu, 31 Aug 2017 21:18:24 +0000
>Subject: [PATCH] Bug 19228: Trigger confirm delete when removing item from
> course
>
>To test:
>1) Enable UseCourseReserves syspref
>2) Go to Course Reserves
>3) Add a new course if you don't already have one
>4) Add an item to the course
>5) Click 'remove' to delete the item from the course
>6) Notice the item deletes straight away with no confirmation prompt
>7) Apply the patch
>8) Repeat steps 4 and 5
>9) Confirm the confirmation box pops up and works as expected
>
>Sponsored-by: Catalyst IT
>Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
>---
> .../prog/en/modules/course_reserves/course-details.tt          | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>index 3e6f8c3..e07cbe5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>@@ -18,8 +18,8 @@
>             ]
>         }));
> 
>-        $("a.delete_item").click(function(){
>-            return confirm( _("Are you sure you want to remove this item from the course?"));
>+        $(".delete_item").click(function(){
>+            return confirmDelete(_("Are you sure you want to remove this item from the course?"));
>         });
> 
>         $("#delete_course").click(function(){
>@@ -207,11 +207,11 @@
> 
>                                     [% IF CAN_user_coursereserves_delete_reserves %]
>                                         [% IF cr.item.onloan %]
>-                                            <a class="btn btn-default btn-xs disabled checkedout" href="#" class="delete_item" data-toggle="tooltip" data-placement="left" title="This item is checked out">
>+                                            <a class="btn btn-default btn-xs disabled checkedout delete_item" href="#" data-toggle="tooltip" data-placement="left" title="This item is checked out">
>                                         [% ELSIF cr.item.itemlost %]
>-                                            <a class="btn btn-default btn-xs disabled itemlost" href="#" class="delete_item" data-toggle="tooltip" data-placement="left" title="This item is lost">
>+                                            <a class="btn btn-default btn-xs disabled itemlost delete_item" href="#" data-toggle="tooltip" data-placement="left" title="This item is lost">
>                                         [% ELSE %]
>-                                            <a class="btn btn-default btn-xs" href="course-details.pl?course_id=[% course.course_id %]&amp;action=del_reserve&amp;cr_id=[% cr.cr_id %]" class="delete_item" >
>+                                            <a class="btn btn-default btn-xs delete_item" href="course-details.pl?course_id=[% course.course_id %]&amp;action=del_reserve&amp;cr_id=[% cr.cr_id %]">
>                                         [% END %]
>                                         <i class="fa fa-trash"></i> Remove</a>
>                                     [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19228: 66676 | 66920 | 66952