Attachment 66949 Details for Bug 19268 – Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t

[patch] Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t

Bug-19268-Fix-TestBuilder-parameter-in-CBrancht-an.patch (text/plain), 2.40 KB, created by Jonathan Druart on 2017-09-07 16:52:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-09-07 16:52:49 UTC

Size: 2.40 KB

patch

obsolete

>From efdc7d3b65e43f98cb22295fe368dfb673d0a38e Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 7 Sep 2017 11:48:09 +0200
>Subject: [PATCH] Bug 19268: Fix TestBuilder parameter in C/Branch.t and
> K/P/Messaging.t
>
>The values parameter should be called value.
>See bug 15339.
>
>Test plan:
>Run the adjusted tests.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/db_dependent/Circulation/Branch.t   | 8 ++++----
> t/db_dependent/Koha/Patron/Messages.t | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/t/db_dependent/Circulation/Branch.t b/t/db_dependent/Circulation/Branch.t
>index 2537723b21..1be07d98a3 100644
>--- a/t/db_dependent/Circulation/Branch.t
>+++ b/t/db_dependent/Circulation/Branch.t
>@@ -65,21 +65,21 @@ my $samplebranch2 = $builder->build({ source => 'Branch' });
> # Add itemtypes
> my $no_circ_itemtype = $builder->build({
>     source => 'Itemtype',
>-    values => {
>+    value => {
>         rentalcharge => '0',
>         notforloan   => 0
>     }
> });
> my $sampleitemtype1 = $builder->build({
>     source => 'Itemtype',
>-    values => {
>+    value => {
>         rentalcharge => '10.0',
>         notforloan   => 1
>     }
> });
> my $sampleitemtype2 = $builder->build({
>     source => 'Itemtype',
>-    values => {
>+    value => {
>         rentalcharge => '5.0',
>         notforloan   => 0
>     }
>@@ -87,7 +87,7 @@ my $sampleitemtype2 = $builder->build({
> # Add Category
> my $samplecat     = $builder->build({
>     source => 'Category',
>-    values => {
>+    value => {
>         hidelostitems => 0
>     }
> });
>diff --git a/t/db_dependent/Koha/Patron/Messages.t b/t/db_dependent/Koha/Patron/Messages.t
>index a64327dd06..3bd9767ecf 100644
>--- a/t/db_dependent/Koha/Patron/Messages.t
>+++ b/t/db_dependent/Koha/Patron/Messages.t
>@@ -36,7 +36,7 @@ $schema->storage->txn_begin;
> 
> my $builder        = t::lib::TestBuilder->new;
> my $library        = $builder->build( { source => 'Branch' } );
>-my $patron         = $builder->build( { source => 'Borrower', values => { branchcode => $library->{branchcode} } } );
>+my $patron         = $builder->build( { source => 'Borrower', value => { branchcode => $library->{branchcode} } } );
> my $patron_2       = $builder->build( { source => 'Borrower' } );
> my $nb_of_logaction = get_nb_of_logactions();
> my $nb_of_messages = Koha::Patron::Messages->search->count;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19268: 66918 | 66949