Attachment 66961 Details for Bug 19258 – Bug 19258: Prevent warn when reversing a payment

[patch] Bug 19258: Prevent warn when reversing a payment

Bug-19258-Prevent-warn-when-reversing-a-payment.patch (text/plain), 1.46 KB, created by Jonathan Druart on 2017-09-07 17:41:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-09-07 17:41:15 UTC

Size: 1.46 KB

patch

obsolete

>From 3fd0af73d306e60964d9022da17c4f71a5428453 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Tue, 5 Sep 2017 22:42:14 +0000
>Subject: [PATCH] Bug 19258: Prevent warn when reversing a payment
>
>The following warn is triggered when I click the Reverse button next to
>an individual payment on the Account tab:
>CGI::param called in list context from package
>CGI::Compile::ROOT::home_vagrant_kohaclone_members_boraccount_2epl line
>63, this can lead to vulnerabilities. See the warning in "Fetching the
>value or values of a single named parameter" at /usr/share/perl5/CGI.pm
>line 436.
>
>To test:
>1) Go to a members detail page in staff side, create a manual invoice,
>pay it
>2) Go to the Account tab, click Reverse next to the payment you just
>made
>3) Notice warns
>4) Apply patch and repeat steps 1 & 2
>5) Warns should be gone
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> members/boraccount.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/members/boraccount.pl b/members/boraccount.pl
>index 0cc9487f39..e7d769efaf 100755
>--- a/members/boraccount.pl
>+++ b/members/boraccount.pl
>@@ -60,7 +60,7 @@ unless ( $patron ) {
> }
> 
> if ( $action eq 'reverse' ) {
>-  ReversePayment( $input->param('accountlines_id') );
>+  ReversePayment( scalar $input->param('accountlines_id') );
> }
> 
> if ( $patron->category->category_type eq 'C') {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19258: 66859 | 66860 | 66861 | 66862 | 66864 | 66865 | 66866 | 66867 | 66958 | 66959 | 66960 | 66961