Bugzilla – Attachment 66981 Details for
Bug 19059
Move C4::Reserves::CancelReserve to the Koha::Hold->cancel
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19059: [QA Follow-up] Typo holds for hold
Bug-19059-QA-Follow-up-Typo-holds-for-hold.patch (text/plain), 993 bytes, created by
Marcel de Rooy
on 2017-09-08 07:49:33 UTC
(
hide
)
Description:
Bug 19059: [QA Follow-up] Typo holds for hold
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-09-08 07:49:33 UTC
Size:
993 bytes
patch
obsolete
>From d7e9e40709597520dad7eb5269d21e1c8fb6bafc Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 7 Sep 2017 14:34:18 +0200 >Subject: [PATCH] Bug 19059: [QA Follow-up] Typo holds for hold >Content-Type: text/plain; charset=utf-8 > >Resolves: >The method found is not covered by tests at C4/Reserves.pm line 815. > >Test plan: >Run t/db_dependent/Holds/CancelReserves.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Reserves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 39153bb..521b072 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -812,7 +812,7 @@ sub CancelExpiredReserves { > next if !$cancel_on_holidays && $calendar->is_holiday( $today ); > > my $cancel_params = {}; >- if ( $holds->found eq 'W' ) { >+ if ( $hold->found eq 'W' ) { > $cancel_params->{charge_cancel_fee} = 1; > } > $hold->cancel( $cancel_params ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19059
:
65607
|
65608
|
65609
|
65610
|
65611
|
65630
|
65631
|
65632
|
65633
|
65634
|
65636
|
65637
|
65638
|
65639
|
65640
|
66783
|
66930
|
66975
|
66976
|
66977
|
66978
|
66979
|
66980
| 66981