Attachment 66983 Details for Bug 15438 – Bug 15438: [QA Follow-up] Moving POD statement for CanBookBeIssued

[patch] Bug 15438: [QA Follow-up] Moving POD statement for CanBookBeIssued

Bug-15438-QA-Follow-up-Moving-POD-statement-for-Ca.patch (text/plain), 1.40 KB, created by Marcel de Rooy on 2017-09-08 10:02:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-09-08 10:02:23 UTC

Size: 1.40 KB

patch

obsolete

>From 452171e7f4c87edb29a81c01c3e3ee3aacac953c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 8 Sep 2017 10:14:10 +0200
>Subject: [PATCH] Bug 15438: [QA Follow-up] Moving POD statement for
> CanBookBeIssued
>Content-Type: text/plain; charset=utf-8
>
>The statement for head3 NB ('nota bene'?) looks like a hash key
>in the list of possible return values for $needsconfirmation.
>Moved it up and prefixed it with IMPORTANT.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Circulation.pm | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 2320e72..abb4c50 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -570,7 +570,11 @@ sub TooMany {
> 
> Check if a book can be issued.
> 
>-C<$issuingimpossible> and C<$needsconfirmation> are some hashref.
>+C<$issuingimpossible> and C<$needsconfirmation> are hashrefs.
>+
>+IMPORTANT: The assumption by users of this routine is that causes blocking
>+the issue are keyed by uppercase labels and other returned
>+data is keyed in lower case!
> 
> =over 4
> 
>@@ -662,12 +666,6 @@ sticky due date is invalid or due date in the past
> 
> if the borrower borrows to much things
> 
>-=head3 NB
>-
>-The assumption by users of the routine is that causes blocking
>-the issue are keyed by uppercase labels and other returned
>-data is keyed in lower case
>-
> =cut
> 
> sub CanBookBeIssued {
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15438: 54783 | 54827 | 61738 | 64264 | 64265 | 64266 | 64757 | 66982 | 66983