Bugzilla – Attachment 67008 Details for
Bug 19235
Password visible in OPAC self registration
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19235: Password entry visible in OPAC Self-registration
SIGNED-OFF-Bug-19235-Password-entry-visible-in-OPA.patch (text/plain), 3.01 KB, created by
Nick Clemens (kidclamp)
on 2017-09-08 17:36:03 UTC
(
hide
)
Description:
Bug 19235: Password entry visible in OPAC Self-registration
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-09-08 17:36:03 UTC
Size:
3.01 KB
patch
obsolete
>From bc1ddc06d055be5956f197d48f4d892e2d002242 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 1 Sep 2017 13:16:43 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 19235: Password entry visible in OPAC > Self-registration > >The HTML code was "text" instead of "password". > >TEST PLAN >---------- >1) 'Allow' PatronSelfRegistration system preference >2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT) >3) Open OPAC >4) Click 'Register here' on the right. (/cgi-bin/koha/opac-memberentry.pl) >5) Scroll to bottom >6) enter some passwords > -- visible >7) apply this patch >8) refresh page >9) repeat 5-6 as needed > -- passwords should not be visible while entering >10) run koha qa test tools > >Signed-off-by: Lee Jamison <ldjamison@marywood.edu> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index cd7c60d..d3b89bf 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -813,21 +813,21 @@ > [% IF mandatory.defined('password') %] > <ol> > <li><label for="borrower_password" class="required">Password</label> >- <input type="text" name="borrower_password" id="password" /> >+ <input type="password" name="borrower_password" id="password" /> > <span class="required">Required</span> > </li> > <li><label for="borrower_password2" class="required">Confirm password</label> >- <input type="text" name="borrower_password2" id="password2" /> >+ <input type="password" name="borrower_password2" id="password2" /> > <span class="required">Required</span> > </li> > </ol> > [% ELSE %] > <ol> > <li><label for="borrower_password">Password</label> >- <input type="text" name="borrower_password" id="password" /> >+ <input type="password" name="borrower_password" id="password" /> > </li> > <li><label for="borrower_password2">Confirm password</label> >- <input type="text" name="borrower_password2" id="password2" /> >+ <input type="password" name="borrower_password2" id="password2" /> > </li> > </ol> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19235
:
66759
|
66768
|
66782
| 67008