Bugzilla – Attachment 67083 Details for
Bug 19128
XSS - patron-attr-types.tt, authorised_values.tt and categories.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19128: XSS - admin/authorised_values.tt
Bug-19128-XSS---adminauthorisedvaluestt.patch (text/plain), 3.19 KB, created by
Jonathan Druart
on 2017-09-12 13:36:25 UTC
(
hide
)
Description:
Bug 19128: XSS - admin/authorised_values.tt
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-09-12 13:36:25 UTC
Size:
3.19 KB
patch
obsolete
>From a6c5a2f3b11ea292f442ae9184e5e9a7c40c638e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 12 Sep 2017 10:35:10 -0300 >Subject: [PATCH] Bug 19128: XSS - admin/authorised_values.tt > >--- > .../intranet-tmpl/prog/en/modules/admin/authorised_values.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >index 83983bf..5c17e5d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >@@ -89,12 +89,12 @@ $(document).ready(function() { > <li> > <span class="label">Category</span> > <input type="hidden" name="op" value="add" /> >- <input type="hidden" name="category" value="[% category %]" /> [% category %] >+ <input type="hidden" name="category" value="[% category | html %]" /> [% category | html %] > </li> > <li> > <label for="authorised_value">Authorized value: </label> > [% IF ( action_modify ) %]<input type="hidden" id="id" name="id" value="[% id %]" />[% END %] >- <input type="text" id="authorised_value" name="authorised_value" value="[% authorised_value %]" maxlength="80" class="focus" /> >+ <input type="text" id="authorised_value" name="authorised_value" value="[% authorised_value | html %]" maxlength="80" class="focus" /> > </li> > <li> > <label for="lib">Description: </label> >@@ -156,7 +156,7 @@ $(document).ready(function() { > [% END %] > </fieldset> > <fieldset class="action"> <input type="hidden" name="id" value="[% id %]" /> >- <input type="submit" value="Save" /> <a class="cancel" href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=[% category %]">Cancel</a></fieldset> >+ <input type="submit" value="Save" /> <a class="cancel" href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=[% category | url %]">Cancel</a></fieldset> > </form> > [% END %] > >@@ -164,7 +164,7 @@ $(document).ready(function() { > [% IF op == 'list' %] > > <div id="toolbar" class="btn-toolbar"> >- <a id="addauth" class="btn btn-default btn-sm" href= "/cgi-bin/koha/admin/authorised_values.pl?op=add_form&category=[% category %]"><i class="fa fa-plus"> </i> New authorized value for [% category |html %]</a> >+ <a id="addauth" class="btn btn-default btn-sm" href= "/cgi-bin/koha/admin/authorised_values.pl?op=add_form&category=[% category | url %]"><i class="fa fa-plus"> </i> New authorized value for [% category |html %]</a> > <a id="addcat" class="btn btn-default btn-sm" href= "/cgi-bin/koha/admin/authorised_values.pl?op=add_form"><i class="fa fa-plus"> </i> New category</a> > </div> > >@@ -271,7 +271,7 @@ $(document).ready(function() { > [% ELSE %] > <tr> > [% END %] >- <td>[% loo.authorised_value %]</td> >+ <td>[% loo.authorised_value | html %]</td> > <td>[% loo.lib |html %]</td> > <td>[% loo.lib_opac |html %]</td> > <td>[% IF ( loo.imageurl ) %]<img src="[% loo.imageurl %]" alt=""/>[% ELSE %] [% END %]</td> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19128
:
66090
|
66136
|
66451
| 67083