Attachment 67139 Details for Bug 19317 – Signed off removal of redundant line

[patch] Signed off removal of redundant line

0001-Bug-19317-bug-18966-follow-up-Remove-leftover.patch (text/plain), 1.54 KB, created by Colin Campbell on 2017-09-14 14:52:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Campbell

Created: 2017-09-14 14:52:06 UTC

Size: 1.54 KB

patch

obsolete

>From 24366de62a22133d5abcac032a9ed3a0c941d017 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 14 Sep 2017 10:57:40 -0300
>Subject: [PATCH] Bug 19317: (bug 18966 follow-up) Remove leftover
>
>Nothing important here, but this line should have been removed by bug
>18966:
>
>2177         # Update the fines
>2178         $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE
>issue_id = ?|, undef, $old_checkout->issue_id, $issue->issue_id);
>
>The issue_id is now the same when moved from issues to old_issues. We do
>not need to update the accountlines table.
>
>No test plan here, you need to understand previous changes to validate
>this patch.
>
>Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
>---
> C4/Circulation.pm | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index abb4c50a66..98600c6218 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2175,9 +2175,6 @@ sub MarkIssueReturned {
>         # Create the old_issues entry
>         my $old_checkout = Koha::Old::Checkout->new($issue->unblessed)->store;
> 
>-        # Update the fines
>-        $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id = ?|, undef, $old_checkout->issue_id, $issue->issue_id);
>-
>         # anonymise patron checkout immediately if $privacy set to 2 and AnonymousPatron is set to a valid borrowernumber
>         if ( $privacy == 2) {
>             $dbh->do(q|UPDATE old_issues SET borrowernumber=? WHERE issue_id = ?|, undef, $anonymouspatron, $old_checkout->issue_id);
>-- 
>2.13.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 19317: 67136 | 67139 | 67450