Attachment 67140 Details for Bug 19319 – Bug 19319 - Reflected XSS Vulnerability in opac-MARCdetail.pl

[patch] Bug 19319 - Reflected XSS Vulnerability in opac-MARCdetail.pl

Bug-19319---Reflected-XSS-Vulnerability-in-opac-MA.patch (text/plain), 4.43 KB, created by Kyle M Hall (khall) on 2017-09-14 15:53:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2017-09-14 15:53:24 UTC

Size: 4.43 KB

patch

obsolete

>From 9ae62a9708c6d824107394a733fc148ce72b82f4 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 14 Sep 2017 11:52:08 -0400
>Subject: [PATCH] Bug 19319 - Reflected XSS Vulnerability in opac-MARCdetail.pl
>
>Try going to this URL on your site: /cgi-bin/koha/opac-MARCdetail.pl?biblionumber=2"><TEST>
>
>Test Plan:
>1) Go to /cgi-bin/koha/opac-MARCdetail.pl?biblionumber=2"><TEST>
>2) Note <TEST> is embedded all over the html
>3) Apply this patch
>4) Refresh the page, not the injection is gone!
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-MARCdetail.tt | 12 ++++++------
> opac/opac-MARCdetail.pl                                     |  2 +-
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-MARCdetail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-MARCdetail.tt
>index db570b3..d053aab 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-MARCdetail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-MARCdetail.tt
>@@ -1,6 +1,6 @@
> [% USE Koha %]
> [% INCLUDE 'doc-head-open.inc' %]
>-<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog &rsaquo;  MARC details for record no. [% biblionumber | html %]</title>
>+:title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog &rsaquo;  MARC details for record no. [% biblio.id %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
> [% BLOCK cssinclude %][% END %]
> </head>
>@@ -20,14 +20,14 @@
>                         <div id="catalogue_detail_biblio">
> 
>                             <div id="views">
>-                                <span class="view"><a id="Normalview" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber | html %]">Normal view</a></span>
>+                                <span class="view"><a id="Normalview" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblio.id %]">Normal view</a></span>
>                                 <span class="view current-view"><span id="MARCview">MARC view</span></span>
>-                                [% IF ( ISBD ) %]<span class="view"><a id="ISBDview"  href="/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=[% biblionumber | html %]">ISBD view</a></span>[% END %]
>+                                [% IF ( ISBD ) %]<span class="view"><a id="ISBDview"  href="/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=[% biblio.id %]">ISBD view</a></span>[% END %]
>                             </div>
>-                            <h1 class="title">[% bibliotitle %] (Record no. [% biblionumber | html %])</h1>
>+                            <h1 class="title">[% bibliotitle %] (Record no. [% biblio.id %])</h1>
> 
>                             [% IF ( OPACXSLTDetailsDisplay ) %]
>-                                <div id="switchview_div">[ <a id="switchview" href="/cgi-bin/koha/opac-showmarc.pl?id=[% biblionumber | html %]&amp;viewas=html">view plain</a> ]</div>
>+                                <div id="switchview_div">[ <a id="switchview" href="/cgi-bin/koha/opac-showmarc.pl?id=[% biblio.id %]&amp;viewas=html">view plain</a> ]</div>
>                                 <div id="plainmarc"></div>
>                             [% END %]
> 
>@@ -190,7 +190,7 @@ $(document).ready(function(){
>             $(this).text(_("view labeled"));
>             $("#labeledmarc").hide();
>             if(!loaded){
>-                $("#plainmarc").show().html("<div style=\"margin:1em;padding:1em;border:1px solid #EEE;font-size:150%;\"><img src=\"[% interface %]/[% theme %]/images/loading.gif\" /> "+_("Loading")+"...</div>").load("/cgi-bin/koha/opac-showmarc.pl","id=[% biblionumber | html %]&viewas=html");
>+                $("#plainmarc").show().html("<div style=\"margin:1em;padding:1em;border:1px solid #EEE;font-size:150%;\"><img src=\"[% interface %]/[% theme %]/images/loading.gif\" /> "+_("Loading")+"...</div>").load("/cgi-bin/koha/opac-showmarc.pl","id=[% biblio.id %]&viewas=html");
>                 loaded = 1;
>             } else {
>                 $("#plainmarc").show();
>diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl
>index 9605cdd..334e383 100755
>--- a/opac/opac-MARCdetail.pl
>+++ b/opac/opac-MARCdetail.pl
>@@ -349,7 +349,7 @@ $template->param(
>     item_loop           => \@item_loop,
>     item_header_loop    => \@item_header_loop,
>     item_subfield_codes => \@item_subfield_codes,
>-    biblionumber        => $biblionumber,
>+    biblio              => $biblio,
> );
> 
> output_html_with_http_headers $query, $cookie, $template->output;
>-- 
>2.10.2

Actions: View | Diff | Splinter Review

Attachments on bug 19319: 67140 | 68482 | 68486 | 69513 | 69634 | 69635 | 69656 | 69657 | 69658