Bugzilla – Attachment 67186 Details for
Bug 19233
Add ability to send itemnumbers in report results to batch modification
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19233: (follow-up) Send itemnumbers in report results to batch modification
Bug-19233-follow-up-Send-itemnumbers-in-report-res.patch (text/plain), 3.74 KB, created by
Owen Leonard
on 2017-09-18 15:34:27 UTC
(
hide
)
Description:
Bug 19233: (follow-up) Send itemnumbers in report results to batch modification
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2017-09-18 15:34:27 UTC
Size:
3.74 KB
patch
obsolete
>From c8606e303c4aab1e048a3a8cd57020565b6d8886 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 18 Sep 2017 15:23:38 +0000 >Subject: [PATCH] Bug 19233: (follow-up) Send itemnumbers in report results to > batch modification > >This patch changes the obscure "^" symbol to a styled link with the text >"Batch modify." I think the only disadvantage of this is that it takes >up more space, but it is outweighed by the improved clarity. > >This patch also makes minor indentation corrections to new lines of >HTML. >--- > .../en/modules/reports/guided_reports_start.tt | 60 +++++++++++++--------- > 1 file changed, 37 insertions(+), 23 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 5311927..c7623e4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -38,6 +38,16 @@ > #col1, #col2 { width:45%; float:left; } > #col1 ins, #col2 del { display: none; } > .show_sql { font-family: monospace; } >+ .send_to_item_mod { >+ background-color: #EBF3FF; >+ border: 1px solid #88b0e8; >+ border-radius: 5px; >+ display: inline-block; >+ font-size: 75%; >+ margin: 3px 5px; >+ padding: 3px 5px; >+ white-space: nowrap; >+ } > </style> > [% IF ( saved1 ) %] > <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> >@@ -929,29 +939,33 @@ canned reports and writing custom SQL reports.</p> > > <div class="pages">[% pagination_bar %]</div> > [% UNLESS ( errors ) %] >-<form method="POST" id="report_results"> >-<input type="hidden" name="op" value="show"> >-<table> >-<tr>[% FOREACH header_ro IN header_row %] >- [% IF header_ro.cell == 'itemnumber' %] >- <th>[% header_ro.cell %] <a href="" data-toggle="tooltip" title="Send visible items to batch modification" class="send_to_item_mod">^</a></th> >- [% ELSE %] >- <th>[% header_ro.cell %]</th> >- [% END %] >- [% END %]</tr> >-[% FOREACH result IN results %] >-<tr> >- [% FOREACH cells IN result.cells %] >- [% place = loop.index %] >- [% IF header_row.$place.cell == 'itemnumber' %] >- <input type="hidden" name="[% header_row.$place.cell | html %]" value="[% cells.cell | html %]"> >- [% END %] >- <td>[% cells.cell %]</td> >- [% END %] >-</tr> >-[% END %] >-</table> >-</form> >+ <form method="POST" id="report_results"> >+ <input type="hidden" name="op" value="show" /> >+ <table> >+ <tr> >+ [% FOREACH header_ro IN header_row %] >+ [% IF header_ro.cell == 'itemnumber' %] >+ <th> >+ [% header_ro.cell %] <a href="#" data-toggle="tooltip" title="Send visible items to batch modification" class="send_to_item_mod"><i class="fa fa-pencil"></i> Batch modify</a> >+ </th> >+ [% ELSE %] >+ <th>[% header_ro.cell %]</th> >+ [% END %] >+ [% END %] >+ </tr> >+ [% FOREACH result IN results %] >+ <tr> >+ [% FOREACH cells IN result.cells %] >+ [% place = loop.index %] >+ [% IF header_row.$place.cell == 'itemnumber' %] >+ <input type="hidden" name="[% header_row.$place.cell | html %]" value="[% cells.cell | html %]" /> >+ [% END %] >+ <td>[% cells.cell %]</td> >+ [% END %] >+ </tr> >+ [% END %] >+ </table> >+ </form> > [% END %] > [% END %] > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19233
:
66680
|
67087
|
67186
|
67805
|
67806
|
69920
|
69921
|
72566
|
72567
|
73344
|
73345
|
73346
|
73347
|
73356