Attachment 67228 Details for Bug 17282 – Bug 17282 - Ability to exclude the last line in report results

[patch] Bug 17282 - Ability to exclude the last line in report results

Bug-17282---Ability-to-exclude-the-last-line-in-re.patch (text/plain), 1.98 KB, created by Alex Arnaud on 2017-09-20 07:42:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Arnaud

Created: 2017-09-20 07:42:10 UTC

Size: 1.98 KB

patch

obsolete

>From 027d2068501027b99328c5f13cde07f126618df4 Mon Sep 17 00:00:00 2001
>From: Alex Arnaud <alex.arnaud@biblibre.com>
>Date: Thu, 15 Sep 2016 14:27:24 +0000
>Subject: [PATCH] Bug 17282 - Ability to exclude the last line in report
> results
>
>This patch add a checkbox (exclude last line). This is useful
>when this last is the result of a sql rollup which is the sum
>of each column and make the chart not consistent
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc                    | 3 +++
> .../intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt     | 4 ++++
> 2 files changed, 7 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
>index ebb86ad..0ec5a32 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
>@@ -27,6 +27,9 @@
>                 </select>
>             </div>
> 
>+            <label for="exclude-last">Exclude last line (Rollup)</label>
>+            <input id="exclude-last" name="chart-exclude-last" type="checkbox">
>+
>             [% column = 1 %]
>             <div>
>                 [% FOREACH header IN header_row %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 1cf73b7..71489bd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -965,6 +965,10 @@ canned reports and writing custom SQL reports.</p>
>             headers = [% header_row.json %];
>             var results = [% results.json %]
> 
>+            if ($('input[name="chart-exclude-last"]').prop('checked')) {
>+                results.splice(-1, 1);
>+            }
>+
>             $('select[name="y"]').each(function( index ) {
>                 y_elements.push( $(this).val() );
>             });
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 17282: 55412 | 55442 | 55444 | 55480 | 55582 | 55586 | 55588 | 55604 | 55605 | 55606 | 55607 | 55868 | 55869 | 62529 | 63565 | 63566 | 63567 | 63568 | 63569 | 63570 | 63571 | 67225 | 67226 | 67227 | 67228 | 67229 | 67230 | 67231 | 69174 | 69429 | 69430 | 69493 | 79182 | 79230 | 79308 | 79309 | 79310 | 79311 | 79312 | 79313 | 79337 | 79338 | 79339