Attachment 6729 Details for Bug 5327 – [SIGNED-OFF] Added unit tests for Scrubber

[patch] [SIGNED-OFF] Added unit tests for Scrubber

SIGNED-OFF-Added-unit-tests-for-Scrubber.patch (text/plain), 2.14 KB, created by Katrin Fischer on 2011-12-13 07:05:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2011-12-13 07:05:22 UTC

Size: 2.14 KB

patch

obsolete

>From 232682fd28ea79903ed721df47daa29ec13b3530 Mon Sep 17 00:00:00 2001
>From: Duncan Tyler <duncan@duncan-SoT.wgtn.cat-it.co.nz>
>Date: Fri, 9 Dec 2011 10:19:14 +1300
>Subject: [PATCH] [SIGNED-OFF] Added unit tests for Scrubber
>
>http://bugs.koha-community.org/show_bug.cgi?id=5327
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Test passes.
>---
> t/Scrubber.t |   24 +++++++++++++++++++++---
> 1 files changed, 21 insertions(+), 3 deletions(-)
>
>diff --git a/t/Scrubber.t b/t/Scrubber.t
>index ce1503f..0fe3a60 100755
>--- a/t/Scrubber.t
>+++ b/t/Scrubber.t
>@@ -3,7 +3,7 @@
> use strict;
> use warnings;
> 
>-use Test::More tests => 11;
>+use Test::More tests => 19;
> BEGIN {
> 	use FindBin;
> 	use lib $FindBin::Bin;
>@@ -20,7 +20,7 @@ sub pretty_line {
> 
> my ($scrubber,$html,$result,@types,$collapse);
> $collapse = 1;
>-@types = qw(comment tag);
>+@types = qw(default comment tag staff);
> $html = q|
> <![CDATA[selfdestruct]]&#x5d;>
> <?php  echo(" EVIL EVIL EVIL "); ?>    
>@@ -58,7 +58,7 @@ $collapse and $result =~ s/\s*\n\s*/\n/g;
> print pretty_line('default'), $result, "\n", pretty_line();
> 
> foreach(@types) {
>-	ok($scrubber = C4::Scrubber->new($_), "Constructor: C4::Scrubber->new($_)");
>+	ok($scrubber = C4::Scrubber->new($_), "testing Constructor: C4::Scrubber->new($_)");
> 	ok(printf("# scrubber settings: default %s, comment %s, process %s\n",
> 		$scrubber->default(),$scrubber->comment(),$scrubber->process()),
> 		"Outputting settings from scrubber object (type: $_)"
>@@ -67,4 +67,22 @@ foreach(@types) {
> 	$collapse and $result =~ s/\s*\n\s*/\n/g;
> 	print pretty_line($_), $result, "\n", pretty_line();
> }
>+
>+print "\n\n######################################################\nStart of invalid tests\n";
>+
>+#Test for invalid new entry
>+eval{
>+	C4::Scrubber->new("");
>+	fail("test should fail on entry of ''\n");
>+};
>+pass("Test should have failed on entry of '' (empty string) and it did. YAY!\n");
>+
>+eval{
>+	C4::Scrubber->new("Client");
>+	fail("test should fail on entry of 'Client'\n");
>+};
>+pass("Test should have failed on entry of 'Client' and it did. YAY!\n");
>+
>+print "######################################################\n";
>+
> diag "done.\n";
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 5327: 2716 | 2726 | 5485 | 6236 | 6237 | 6373 | 6560 | 6561 | 6562 | 6563 | 6613 | 6614 | 6616 | 6620 | 6621 | 6622 | 6643 | 6650 | 6655 | 6679 | 6681 | 6682 | 6683 | 6726 | 6727 | 6728 | 6729 | 6730 | 6731 | 6732 | 6795 | 6799 | 6805 | 6819 | 6826 | 6827 | 6828 | 6834 | 7179 | 7180 | 7181 | 7182 | 7183 | 7184 | 7185 | 7186 | 7187 | 7188 | 7189 | 7190 | 7191 | 7192 | 7194 | 7195 | 7203 | 7206 | 7208 | 7209 | 7220 | 7221 | 7222 | 7223 | 7224 | 7225 | 7226 | 7227 | 7228 | 7229 | 7230 | 7231 | 7232 | 7233 | 7234 | 7235 | 7236 | 7237 | 7238 | 7239 | 7240 | 7241 | 7242 | 7400 | 7402 | 7403 | 7405 | 7573 | 7592 | 7593 | 7594 | 9897 | 10234 | 10616 | 10656 | 10659 | 10660 | 10661 | 10680 | 11141 | 11186 | 11212 | 11213 | 11278 | 11279 | 11280 | 11281 | 11339 | 11340 | 11341 | 11440 | 11467 | 11469 | 11470 | 11471 | 11472 | 11473 | 11500 | 11503 | 11505 | 11506 | 11633 | 11762 | 11763 | 11764 | 11765 | 11846 | 11985 | 11993 | 12002 | 12003